CI contains thousands of "Keystroke … is already assigned to …, will be overridden by …" warnings

[simon04]

See ​https://github.com/openstreetmap/josm/runs/1217462347#step:7:220

[stoecker]

Not sure what to do against it. Happens when you really install all the plugins :-)

[simon04]

Not a single plugin is installed. However, using org.openstreetmap.josm.testutils.JOSMTestRules#main() causes org.openstreetmap.josm.gui.MainApplication to be initialised before each unit test.

[Don-vip]

Maybe org.openstreetmap.josm.testutils.JOSMTestRules#main() is no longer needed now we have JMockit?

[Don-vip]

Milestone renamed

[simon04]

This fixes many log messages. Any objections?

test/unit/org/openstreetmap/josm/gui/MainApplicationTest.java

@@ -66 +66 @@
      * Make sure {@link MainApplication#contentPanePrivate} is initialized.
      */
     public static void initContentPane() {
-        if (MainApplication.contentPanePrivate == null) {
-            MainApplication.contentPanePrivate = new JPanel(new BorderLayout());
-        }
+        // init every time to avoid "Keystroke %s is already assigned to %s"
+        MainApplication.contentPanePrivate = new JPanel(new BorderLayout());
     }
 
     /**
@@ -103 +102 @@
      * Make sure {@link MainApplication#toolbar} is initialized.
      */
     public static void initToolbar() {
-        if (MainApplication.toolbar == null) {
-            MainApplication.toolbar = new ToolbarPreferences();
-        }
+        // init every time to avoid "Registered toolbar action"
+        MainApplication.toolbar = new ToolbarPreferences();
     }
 
     @SuppressFBWarnings(value = "DM_DEFAULT_ENCODING")

The following log messages remain:

2021-03-29 20:09:29.926 INFO: Reassigning macOS shortcut 'help:search-items' from Meta to Ctrl because of conflict with ⌘+␣
2021-03-29 20:09:29.927 INFO: Silent shortcut conflict: 'help:search-items' moved by 'apple-reserved-01' to '⌃+␣'.
2021-03-29 20:09:29.927 INFO: Reassigning macOS shortcut 'core:historyinfo' from Meta to Ctrl because of conflict with ⌘+H
2021-03-29 20:09:29.927 INFO: Silent shortcut conflict: 'core:historyinfo' moved by 'system:hide' to '⌃+H'.
2021-03-29 20:09:30.100 INFO: Reassigning macOS shortcut 'file:downloadreferrers' from Meta to Ctrl because of conflict with ⌘+⌥+D
2021-03-29 20:09:30.100 INFO: Silent shortcut conflict: 'file:downloadreferrers' moved by 'apple-reserved-42' to '⌃+⌥+D'.

Too bad we cannot use java.util.logging.Logger#setLevel for the org.openstreetmap.josm.tools.Shortcut logger only...

[Don-vip]

No objection. It's only test code :)

[simon04]

In 17687/josm:

fix #19889 - CI contains thousands of "Keystroke ... is already assigned to ..., will be overridden by ..." warnings