Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#19858 closed enhancement (othersoftware)

water=tidal without intermittent

Reported by: josm.sanspourriel Owned by: josm.sanspourriel
Priority: normal Milestone:
Component: Core validator Version: tested
Keywords: Cc:

Description

https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss
natural without water=intermittent on https://www.openstreetmap.org/way/228749517.

I don't get it, at least the error message should be improved. water=tidal implies that it's intermittent.
I guess the error is just the opposite (water=... without natural=water).

Attachments (0)

Change History (7)

comment:1 by Klumbumbus, 5 years ago

Owner: changed from team to josm.sanspourriel
Status: newneedinfo

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

  • The required parts of the Status Report from your JOSM.
  • Describe what behaviour you expected.
  • Describe what did happen instead.
  • Describe if and how the issue is reproducible.
  • Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Helpsource:trunk/resources/images/bug.svg Report Bug.

Remember: This is a generic notice so we don't need to write the same stuff again and again. It may only apply in parts to the specific case!


comment:2 by josm.sanspourriel, 5 years ago

Hi, what to you need? I can't join a bug report as it's not a bug but an enhancement request.

what I expect : no error message or a meaningful one. I don't know what the developer wanted to check so I can only make an educated guess.

in reply to:  2 comment:3 by skyper, 5 years ago

Please, read comment #2, carefully. We need some parts of the Status Report. One line below, it is explained how you get the relevant parts.

Additionally, it is possible to copy the complete validator warning and add it to the description.

in reply to:  2 comment:4 by Klumbumbus, 5 years ago

Replying to josmjosm <josm.sanspourriel@…>:

Hi, what to you need?

For me it doesn't warn "natural without water=intermittent" on https://www.openstreetmap.org/way/228749517. Thats why we need:

  • your status report
  • your description in the bug report form from Help -> Report Bug
  • a screenshot showing the validated data and the validator message

comment:5 by josm.sanspourriel, 5 years ago

For me it doesn't warn "natural without water=intermittent" on

https://www.openstreetmap.org/way/228749517.

Note: the error message from JOSM is completely different and seems to be OK to me...

attribut manquant - water sans natural=water|bay|strait (1)
attributs dépréciés - water=tidal est déprécié, utilisez tidal=yes à la place (1)

And the current error message in Osmose is now OK:

attributs dépréciés

water=tidal est déprécié

So you can close the ticket.
Thanks.

comment:6 by Klumbumbus, 5 years ago

Resolution: othersoftware
Status: needinfoclosed

Please also note that water=tidal is deprecated. And https://www.openstreetmap.org/way/228749517 is even on a unclosed way which makes this object even "more wrong".

comment:7 by josm.sanspourriel, 5 years ago

Please also note that water=tidal is deprecated.

Indeed, that's the origin of the issue: the issue was not that reporting the error was wrong but that the report (in Osmose) was wrong.

And https://www.openstreetmap.org/way/228749517 is even on a unclosed way which makes this object even "more wrong".

Yes, I saw that and asked the originator of the way if he wanted to empty the sea that way ;-).
Another way (https://www.openstreetmap.org/way/572734801) should be merged to create a close ring or used in a multi-polygon relation, we are on the same page.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain josm.sanspourriel.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.