Modify

Opened 3 years ago

Last modified 3 years ago

#19748 new defect

Risky autofix: Incorrect roundabout (highway: primary instead of {trunk/motorway})

Reported by: Famlam Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: template_report roundabout trunk motorway Cc:

Description

What steps will reproduce the problem?

  1. Validate attached file
  2. Incorrect roundabout (highway: primary instead of trunk)

What is the expected result?

No warning (this roundabout isn't trunk; the road sign to end the trunk is ~10m before the roundabout).
I think for highway=trunk and highway=motorway it's much less likely to encounter a (small) roundabout that is also trunk/motorway. More likely the trunk/motorway status ends just before the roundabout.

What happens instead?

Warning and bad autofix

Please provide any additional information below. Attach a screenshot if possible.

Suggestion: if the connecting road is motorway / motorway_link / trunk / trunk_link and the roundabout is highway=primary, skip the check. (Or perhaps set priority to "other" instead of "warning")

Alternative suggestion: do not provide an autofix and change the warning to something more flexible, like: Multiple {connecting_highway_tag} connections to a roundabout with {roundabout_highway_tag}. Check the roundabout or connections.

Mapillary image with the roundabout and the "end of trunk" traffic sign.

The error is in Highways.java -> testWrongRoundabout(...)


URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-30 12:44:04 +0200 (Thu, 30 Jul 2020)
Build-Date:2020-07-31 01:30:49
Revision:16812
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16812 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 808 MB / 1820 MB (507 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ imagery_offset_db (35405)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ undelete (35521)
+ utilsplugin2 (35487)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Attachments (1)

dangerous autofix.osm (85.3 KB) - added by Famlam 3 years ago.
Example file containing the roundabout

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by Famlam

Attachment: dangerous autofix.osm added

Example file containing the roundabout

comment:1 Changed 3 years ago by skyper

The definition of highway=motorway and highway=trunk usually contradicts with a roundabout. As *_link is not appropriate in most cases primary should be the first choice.

comment:2 in reply to:  1 Changed 3 years ago by Klumbumbus

Replying to skyper:

The definition of highway=motorway and highway=trunk usually contradicts with a roundabout. As *_link is not appropriate in most cases primary should be the first choice.

Regarding trunk thats true for germany, but not for other countries. It is very common there that trunks include roundabouts. https://overpass-turbo.eu/s/XD0 (36k ways global)

comment:3 Changed 3 years ago by Famlam

True, however, if for two (probably more) countries (NL & DE) it is a very unlikely scenario, I would definitely still be in favor of at least rephrasing the message to be less "it must be" and more "it could be" ;)

comment:4 Changed 3 years ago by skyper

I checked wiki pages about trunk in Dutch, English, French, German, Portuguese and Spanish. Did not find any description which includes roundabouts though, the are often only little words about each Country.

comment:5 Changed 3 years ago by Famlam

In The Netherlands it's restricted to "Autoweg" (trunk) and "Autosnelweg" (motorroad): legally defined roads with the traffic signs listed in the first table on this page.
i.e., between this and this sign is highway=motorway, and this to this defines highway=trunk

Seems to be the case in Belgium too.
And for Germany it is at least always the case for motorway (around the middle of the wiki) and often for trunk.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Famlam
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.