id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
19748	Risky autofix: Incorrect roundabout (highway: primary instead of {trunk/motorway})	Famlam	team	"==== What steps will reproduce the problem?
1. Validate attached file
2. ''Incorrect roundabout (highway: primary instead of trunk)''

==== What is the expected result?
No warning (this roundabout isn't trunk; the road sign to end the trunk is ~10m before the roundabout).
I think for `highway=trunk` and `highway=motorway` it's much less likely to encounter a (small) roundabout that is also trunk/motorway. More likely the trunk/motorway status ends just before the roundabout.

==== What happens instead?
Warning and bad autofix

==== Please provide any additional information below. Attach a screenshot if possible.
Suggestion: if the connecting road is motorway / motorway_link / trunk / trunk_link and the roundabout is `highway=primary`, skip the check. (Or perhaps set priority to ""other"" instead of ""warning"")

Alternative suggestion: do not provide an autofix and change the warning to something more flexible, like: ''Multiple {connecting_highway_tag} connections to a roundabout with {roundabout_highway_tag}. Check the roundabout or connections.''

[https://www.mapillary.com/app/?lat=51.79151976128049&lng=5.718302878353658&z=17&focus=photo&pKey=0jnjbGlAV1W2Ehk2oWswPw Mapillary] image with the roundabout and the ""end of trunk"" traffic sign.

The error is in [https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/Highways.java#L112 Highways.java -> testWrongRoundabout(...)]


----


{{{
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-30 12:44:04 +0200 (Thu, 30 Jul 2020)
Build-Date:2020-07-31 01:30:49
Revision:16812
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16812 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 808 MB / 1820 MB (507 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ imagery_offset_db (35405)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ undelete (35521)
+ utilsplugin2 (35487)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss
}}}
"	defect	new	normal		Core validator	latest		template_report roundabout trunk motorway