#19647 closed enhancement (fixed)
[PATCH] Exclude all but ways with highway=* from Lanes.java test
| Reported by: | skyper | Owned by: | GerdP |
|---|---|---|---|
| Priority: | normal | Milestone: | 21.05 |
| Component: | Core validator | Version: | |
| Keywords: | template_report lanes-tagging Lanes.java performance | Cc: | GerdP |
Description
For better performance, Lanes.java should only be run on ways with highway=*.
r16198 included some general restrictions but it could be stricter. Or do I misread the code?
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2020-08-06 21:47:58 +0200 (Thu, 06 Aug 2020) Revision:16851 Build-Date:2020-08-07 01:30:47 URL:https://josm.openstreetmap.de/svn/trunk
Attachments (3)
Change History (9)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
| Summary: | Exclude all but ways with highway=* from Lanes.java test → [PATCH] Exclude all but ways with highway=* from Lanes.java test |
|---|
follow-up: 5 comment:3 by , 5 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
I was not sure if highways are the only objects for which this test should be executed, but it seems true.
comment:5 by , 5 years ago
Replying to GerdP:
I was not sure if highways are the only objects for which this test should be executed, but it seems true.
There might be few more tags but only checking the majority is fine, as there are only low numbers of use beside highway=*.
comment:6 by , 4 years ago
| Milestone: | → 21.05 |
|---|



so an addition like p.hasTag("highway") is what you are looking for in the isPrimitiveUsable function to be more strict about when this validation is used?