Modify

Opened 2 years ago

Closed 19 months ago

Last modified 17 months ago

#19647 closed enhancement (fixed)

[PATCH] Exclude all but ways with highway=* from Lanes.java test

Reported by: skyper Owned by: GerdP
Priority: normal Milestone: 21.05
Component: Core validator Version:
Keywords: template_report lanes-tagging Lanes.java performance Cc: GerdP

Description

For better performance, Lanes.java should only be run on ways with highway=*.

r16198 included some general restrictions but it could be stricter. Or do I misread the code?

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-08-06 21:47:58 +0200 (Thu, 06 Aug 2020)
Revision:16851
Build-Date:2020-08-07 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (3)

Lanes.java-patch (855 bytes) - added by Gabe 19 months ago.
patch for Lanes.java
19647.patch.patch (855 bytes) - added by Gabe 19 months ago.
correct extension
19647.patch (855 bytes) - added by Gabe 19 months ago.
REAL correct extension.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 19 months ago by Gabe

so an addition like p.hasTag("highway") is what you are looking for in the isPrimitiveUsable function to be more strict about when this validation is used?

Changed 19 months ago by Gabe

Attachment: Lanes.java-patch added

patch for Lanes.java

comment:2 Changed 19 months ago by anonymous

Summary: Exclude all but ways with highway=* from Lanes.java test[PATCH] Exclude all but ways with highway=* from Lanes.java test

Changed 19 months ago by Gabe

Attachment: 19647.patch.patch added

correct extension

Changed 19 months ago by Gabe

Attachment: 19647.patch added

REAL correct extension.

comment:3 Changed 19 months ago by GerdP

Owner: changed from team to GerdP
Status: newassigned

I was not sure if highways are the only objects for which this test should be executed, but it seems true.

comment:4 Changed 19 months ago by GerdP

Resolution: fixed
Status: assignedclosed

In 17861/josm:

fix #19647: Exclude all but ways with highway=* from Lanes.java test

  • make isPrimitiveUsable() more restrictive (patch by Gabe, modified)

Unit tests bypass this method so they need no changes.

comment:5 in reply to:  3 Changed 19 months ago by skyper

Replying to GerdP:

I was not sure if highways are the only objects for which this test should be executed, but it seems true.

There might be few more tags but only checking the majority is fine, as there are only low numbers of use beside highway=*.

Last edited 19 months ago by skyper (previous) (diff)

comment:6 Changed 17 months ago by Don-vip

Milestone: 21.05

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.