Modify

Opened 7 weeks ago

Closed 7 weeks ago

Last modified 6 weeks ago

#19646 closed enhancement (fixed)

Preset "bunker" should use building=bunker instead of building=yes

Reported by: bagage Owned by: Klumbumbus
Priority: normal Milestone: 20.08
Component: Internal preset Version:
Keywords: template_report bunker building Cc:

Description

What steps will reproduce the problem?

  1. Draw a building
  2. Add "bunker" preset

What is the expected result?

Tags should be "building=bunker military=bunker"

What happens instead?

Tags are "building=yes military=bunker"

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-06-30 19:13:42 +0200 (Tue, 30 Jun 2020)
Revision:16731
Build-Date:2020-07-01 01:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16731 fr) Linux Debian GNU/Linux bullseye/sid
Memory Usage: 464 MB / 4994 MB (92 MB allocated, but free)
Java version: 11.0.8+10-post-Debian-1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Java package: openjdk-11-jre:amd64-11.0.8+10-1
Java ATK Wrapper package: libatk-wrapper-java:all-0.38.0-1
libcommons-compress-java: libcommons-compress-java:-
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20200323-1
liboauth-signpost-java: liboauth-signpost-java:-
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (35405)
+ HouseNumberTaggingTool (35508)
+ OpeningHoursEditor (35414)
+ PicLayer (35405)
+ apache-commons (35362)
+ buildings_tools (35500)
+ cadastre-fr (35405)
+ conflation (0.6.5)
+ ejml (35313)
+ geotools (35169)
+ jts (35122)
+ measurement (35405)
+ poly (35248)
+ reverter (35499)
+ scripting (30796)
+ terracer (35499)
+ todo (30306)
+ utilsplugin2 (35487)

Last errors/warnings:
- W: Unknown remote control parameter title, skipping it
- W: Unknown remote control parameter title, skipping it
- E: Erreur I/O durant la création du fichier, la sauvegarde automatique sera ignorée : Nom de fichier trop long: java.io.IOException: Nom de fichier trop long
- W: Unknown remote control parameter title, skipping it
- W: Unknown remote control parameter title, skipping it

Attachments (0)

Change History (8)

comment:1 Changed 7 weeks ago by skyper

Component: CoreInternal preset
Keywords: bunker building added
Type: defectenhancement

building=yes is not wrong, e.g. enhancement and not a defect.

Last edited 7 weeks ago by skyper (previous) (diff)

comment:2 Changed 7 weeks ago by skyper

Owner: changed from team to skyper
Status: newassigned

Coincidentally, I created #19642, yesterday. Will fix this there.

comment:3 in reply to:  2 Changed 7 weeks ago by Klumbumbus

Replying to skyper:

Coincidentally, I created #19642, yesterday. Will fix this there.

No, don't mix this.

comment:4 Changed 7 weeks ago by Klumbumbus

Milestone: 20.08
Owner: changed from skyper to Klumbumbus
Status: assignednew

military=bunker does not imply building=*. E.g. if a bunker is an adit it is not a building. However we can add a building=bunker drop down list to the military=bunker preset

comment:5 Changed 7 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16852/josm:

fix #19646 - Enhance bunker preset

comment:6 in reply to:  5 Changed 7 weeks ago by skyper

Replying to Klumbumbus:

In 16852/josm:

fix #19646 - Enhance bunker preset

Please, allow to search on values of bunker_type. Thanks

comment:7 Changed 7 weeks ago by Klumbumbus

In 16853/josm:

see #19646 - Enhance bunker preset

comment:8 Changed 6 weeks ago by Klumbumbus

In 16889/josm:

see #19646 - add bunker value also to building preset

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.