Opened 6 years ago

Last modified 6 years ago

#19583 closed enhancement

[patch] unused icons active-pressed and eye-pressed — at Initial Version

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 20.08
Component: Core Version:
Keywords: template_report Cc:

Description

The icons source:trunk/resources/images/dialogs/layerlist/active-pressed.png dialogs/layerlist/active-pressed and source:trunk/resources/images/dialogs/layerlist/eye-pressed.png dialogs/layerlist/eye-pressed are actually never used in JOSM, or are they in different OS/LookAndFeel?

They don't make much sense to me anyway.

Is it fine to remove the two icons and these two lines? (These are the two only occurrences of setPressedIcon in the whole JOSM code.)

  • LayerListDialog.java

     
    465465            setSelectedIcon(active);
    466466            setRolloverIcon(blank);
    467467            setRolloverSelectedIcon(active);
    468             setPressedIcon(ImageProvider.get("dialogs/layerlist", "active-pressed"));
    469468        }
    470469    }
    471470
     
    482481            iconEye = new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye");
    483482            iconEyeTranslucent = new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye-translucent", true);
    484483            setIcon(ImageProvider.get("dialogs/layerlist", "eye-off"));
    485             setPressedIcon(new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye-pressed"));
    486484            setSelectedIcon(iconEye);
    487485            isTranslucent = false;
    488486        }
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-25 14:35:24 +0200 (Sat, 25 Jul 2020)
Build-Date:2020-07-26 01:30:54
Revision:16808
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16808 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 723 MB / 1820 MB (302 MB allocated, but free)
Java version: 1.8.0_251-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1680x1050 (scaling 1.0x1.0)
Maximum Screen Size: 1680x1050
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=49841, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Change History (0)

Note: See TracTickets for help on using tickets.