In case of OSM server failure provide generic error message

[mkoniecz]

What steps will reproduce the problem? ¶

1. break OSM server? Mock OSM server and return empty error?

What is the expected result? ¶

I get generic error message, not an empty message

What happens instead? ¶

I get an empty error message

Please provide any additional information below. Attach a screenshot if possible. ¶

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-06-30 19:13:42 +0200 (Tue, 30 Jun 2020)
Revision:16731
Build-Date:2020-07-01 01:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16731 en_GB) Linux Ubuntu 20.04 LTS
Memory Usage: 508 MB / 976 MB (139 MB allocated, but free)
Java version: 11.0.7+10-post-Ubuntu-3ubuntu1, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Java package: openjdk-11-jre:amd64-11.0.7+10-3ubuntu1
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (35500)
+ measurement (35405)
+ reverter (35499)
+ todo (30306)

Last errors/warnings:
- E: Communication with OSM server failed - null

[mkoniecz]

Seems similar but not exact clone of #19565

[skyper]

Closed as duplicate of #19412.

[skyper]

Damn, sorry, closed the wrong ticket.

[katpatuka]

yep - looks a bit strange...

Console msg reads

2021-09-14 09:20:25.218 SEVERE: Communication with OSM server failed - null

Instead of null I'd expect something like

• Timeout error - please try again later or
• Server has been shutdown - contact your admin

;)

[mdk]

I'm not sure, but it looks like an error is catched and a new error is generated with the causing exception at end of the message. The causing error has a null message and null messages are normally NPE.

If you change to Java 15+ NPE will generate a Helpful NullPointerException (like "Cannot invoke "com.howtodoinjava.core.basic.Employee.getName()" because "e" is null").