[RFC Patch] Don't store cached file information in preferences

[taylor.smock]

Since, as far as I know, JOSM Preferences never clears out old entries, it would be nice to avoid adding unnecessary entries.

The attached patch does the following:

• Uses file metadata to get the age of the file
• Adds an option to have files deleted on graceful exit (does not delete files if the exit is forced).

This is an RFC since (AFAIK) there are not commonly used file systems which do not store the modification time.

[taylor.smock]

Initial RFC patch

[GerdP]

can you explain what "unnecessary entries" you mean?

[GerdP]

Ah, probably entries like this:

  <list key='mirror.C:\Users\Gerd\AppData\Local\JOSM\cache\images.https://raw.githubusercontent.com/OpenNauticalChart/josm/master/icons/svg/Q/Q126/CEVNI/berthing_lateral_limit.svg'>
    <entry value='1548567266688'/>
    <entry value='C:\Users\Gerd\AppData\Local\JOSM\cache\images\mirror_https___raw.githubusercontent.com_OpenNauticalChart_josm_master_icons_svg_Q_Q126_CEVNI_berthing_lateral_limit.svg'/>
  </list>

[taylor.smock]

I originally copied the CachedFile source into the OpenQA plugin (since I usd it to get data from various QA APIs -- I didn't want to accidentally overload someone's server). I made some modifications there so that I wouldn't make JOSM Preferences explode in size.

But yes, that would probably be another entry that would be unnecessary.

[stoecker]

Hmm, I'm not enthusiastic about the proposal. Why not simply add a cleanup function in Prefs loader which clean unnecessary stuff from time to time (i.e. with version upgrades)?

[taylor.smock]

Add a cleanup function to preferences

[taylor.smock]

Replying to stoecker:

Hmm, I'm not enthusiastic about the proposal. Why not simply add a cleanup function in Prefs loader which clean unnecessary stuff from time to time (i.e. with version upgrades)?

I've added a cleanup function (it isn't perfect, and it definitely needs more work, but I think it is the direction you were talking about).