Modify

Opened 16 months ago

Last modified 13 months ago

#19538 new defect

JOSM blocked after request to upload

Reported by: leni Owned by: team
Priority: normal Milestone:
Component: Plugin pt_assistant Version:
Keywords: template_report Cc: Biswesh, darya, giackserva

Description

What steps will reproduce the problem?

  1. download tad120_1.osm file
  2. request to upload

What is the expected result?

validator and upload data

What happens instead?

JOSM blocked, nothing can be activated, I keel process.
It's the same if I begin creating a bus_top and add it to a bus relation

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-06-30 19:13:42 +0200 (Tue, 30 Jun 2020)
Build-Date:2020-07-01 01:30:51
Revision:16731
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16731 fr) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 800 MB / 1751 MB (486 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.23)
+ apache-commons (35362)
+ apache-http (35092)
+ buildings_tools (35500)
+ changeset-viewer (22)
+ ejml (35313)
+ geotools (35169)
+ imagery_offset_db (35405)
+ javafx-windows (35458)
+ jaxb (35092)
+ jna (35092)
+ jts (35122)
+ measurement (35405)
+ opendata (35405)
+ photo_geotagging (35499)
+ photoadjust (35405)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35499)
+ shrinkwrap (v1.0.2)
+ tageditor (35258)
+ utilsplugin2 (35487)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1

Validator rules:
+ https://raw.githubusercontent.com/nlehuby/transport_mapcss/master/transport.validator.mapcss

Last errors/warnings:
- W: Avertissement: le scan du fichier 'fr.toulouse.jar' pour le module d'information a échoué. Action ignorée.
- E: Handled by bug report queue: java.lang.NullPointerException
- W: Avertissement - <html>JOSM ne parvient pas à trouver d’information sur les greffons suivants :<ul><li>imagery_offset_db</li><li>apache-commons</li><li>photoadjust</li><li>geotools</li><li>tageditor</li><li>opendata</li><li>jts</li><li>Mapillary</li><li>changeset-viewer</li><li>javafx-windows</li><li>ejml</li><li>reverter</li><li>measurement</li><li>jaxb</li><li>pt_assistant</li><li>utilsplugin2</li><li>photo_geotagging</li><li>buildings_tools</li><li>wikipedia</li><li>jna</li><li>shrinkwrap</li><li>apache-http</li></ul>Les greffons ne seront pas chargés.</html>


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: JavaFX Application Thread (63) of main
java.lang.NullPointerException
	at com.sun.javafx.text.PrismTextLayout.createLine(PrismTextLayout.java:892)
	at com.sun.javafx.text.PrismTextLayout.layout(PrismTextLayout.java:1192)
	at com.sun.javafx.text.PrismTextLayout.ensureLayout(PrismTextLayout.java:223)
	at com.sun.javafx.text.PrismTextLayout.getBounds(PrismTextLayout.java:246)
	at javafx.scene.text.Text.getLogicalBounds(Text.java:358)
	at javafx.scene.text.Text.getYRendering(Text.java:1069)
	at javafx.scene.text.Text.access$4400(Text.java:95)
	at javafx.scene.text.Text$TextAttribute$11.computeValue(Text.java:1785)
	at javafx.scene.text.Text$TextAttribute$11.computeValue(Text.java:1777)
	at javafx.beans.binding.ObjectBinding.get(ObjectBinding.java:153)
	at javafx.beans.binding.ObjectExpression.getValue(ObjectExpression.java:50)
	at javafx.beans.property.ObjectPropertyBase.get(ObjectPropertyBase.java:132)
	at com.sun.javafx.scene.control.skin.TextFieldSkin.lambda$new$4(TextFieldSkin.java:233)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:137)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
	at javafx.beans.property.ObjectPropertyBase.fireValueChangedEvent(ObjectPropertyBase.java:105)
	at javafx.beans.property.ObjectPropertyBase.markInvalid(ObjectPropertyBase.java:112)
	at javafx.beans.property.ObjectPropertyBase.access$000(ObjectPropertyBase.java:51)
	at javafx.beans.property.ObjectPropertyBase$Listener.invalidated(ObjectPropertyBase.java:233)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:137)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
	at javafx.beans.binding.ObjectBinding.invalidate(ObjectBinding.java:172)
	at com.sun.javafx.binding.BindingHelperObserver.invalidated(BindingHelperObserver.java:51)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:137)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
	at javafx.beans.property.IntegerPropertyBase.fireValueChangedEvent(IntegerPropertyBase.java:106)
	at javafx.beans.property.IntegerPropertyBase.markInvalid(IntegerPropertyBase.java:113)
	at javafx.beans.property.IntegerPropertyBase.set(IntegerPropertyBase.java:147)
	at javafx.scene.text.Text.setImpl_caretPosition(Text.java:923)
	at com.sun.javafx.scene.control.skin.TextFieldSkin.updateTextNodeCaretPos(TextFieldSkin.java:367)
	at com.sun.javafx.scene.control.skin.TextFieldSkin.lambda$new$4(TextFieldSkin.java:236)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:137)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
	at javafx.beans.property.ObjectPropertyBase.fireValueChangedEvent(ObjectPropertyBase.java:105)
	at javafx.beans.property.ObjectPropertyBase.markInvalid(ObjectPropertyBase.java:112)
	at javafx.beans.property.ObjectPropertyBase.access$000(ObjectPropertyBase.java:51)
	at javafx.beans.property.ObjectPropertyBase$Listener.invalidated(ObjectPropertyBase.java:233)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:137)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
	at javafx.beans.binding.ObjectBinding.invalidate(ObjectBinding.java:172)
	at javafx.scene.text.Text.impl_geomChanged(Text.java:769)
	at javafx.scene.text.Text.needsTextLayout(Text.java:194)
	at javafx.scene.text.Text.access$900(Text.java:95)
	at javafx.scene.text.Text$6.invalidated(Text.java:566)
	at javafx.beans.property.ObjectPropertyBase.markInvalid(ObjectPropertyBase.java:111)
	at javafx.beans.property.ObjectPropertyBase.set(ObjectPropertyBase.java:146)
	at javafx.css.StyleableObjectProperty.set(StyleableObjectProperty.java:82)
	at javafx.css.StyleableObjectProperty.applyStyle(StyleableObjectProperty.java:68)
	at javafx.scene.CssStyleHelper.transitionToState(CssStyleHelper.java:774)
	at javafx.scene.Node.impl_processCSS(Node.java:9196)
	at javafx.scene.Parent.impl_processCSS(Parent.java:1280)
	at javafx.scene.Parent.impl_processCSS(Parent.java:1280)
	at javafx.scene.control.Control.impl_processCSS(Control.java:868)
	at javafx.scene.Node.processCSS(Node.java:9063)
	at javafx.scene.Node.processCSS(Node.java:9056)
	at javafx.scene.Node.processCSS(Node.java:9056)
	at javafx.scene.Scene.doCSSPass(Scene.java:545)
	at javafx.scene.Scene.access$3600(Scene.java:159)
	at javafx.scene.Scene$ScenePulseListener.pulse(Scene.java:2392)
	at com.sun.javafx.tk.Toolkit.lambda$runPulse$2(Toolkit.java:398)
	at java.security.AccessController.doPrivileged(Native Method)
	at com.sun.javafx.tk.Toolkit.runPulse(Toolkit.java:397)
	at com.sun.javafx.tk.Toolkit.firePulse(Toolkit.java:424)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:561)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:541)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:534)
	at com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:340)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
	at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at com.sun.glass.ui.win.WinApplication.lambda$null$4(WinApplication.java:186)
	at java.lang.Thread.run(Unknown Source)

Attachments (2)

processxpJosm.png (22.4 KB) - added by leni 16 months ago.
Process when blocked
tad120_1.osm (488.6 KB) - added by leni 16 months ago.
osm file

Download all attachments as: .zip

Change History (17)

Changed 16 months ago by leni

Attachment: processxpJosm.png added

Process when blocked

Changed 16 months ago by leni

Attachment: tad120_1.osm added

osm file

comment:1 Changed 16 months ago by taylor.smock

Owner: changed from team to leni
Status: newneedinfo

Can you check and see if this occurs with JavaFX turned off for Mapillary? (JOSM Preferences -> Display Settings -> Mapillary -> uncheck Use JavaFX for better looking dialogs)

I wasn't able to reproduce on my machine.

comment:2 Changed 16 months ago by skyper

Component: CorePlugin javafx

comment:3 in reply to:  1 Changed 16 months ago by leni

Replying to taylor.smock:

Can you check and see if this occurs with JavaFX turned off for Mapillary?

same issue

comment:4 Changed 16 months ago by leni

Component: Plugin javafxCore

comment:5 Changed 16 months ago by skyper

Component: CorePlugin javafx

Dear leni

The stack trace clearly states, that this is a problem with javafx or did you have the same problem without the plugin?

comment:6 Changed 16 months ago by leni

I have the same whitout javafx (I have not new stack trace)
I am removing the other plugins individually to see if it is them or my system; I'll let you know when I've removed everything.

comment:7 Changed 16 months ago by skyper

I usually start testing without any plugins and an empty preference directories by specifying a different JOSM directory. Renaming/Moving the JOSM folders works, too. Please, add a new stack trace without the javafx plugin.

comment:8 Changed 15 months ago by leni

When I move preferences.xml, josm is ok.
That is why I put back the preferences.xml that are causing problems and I test after removing the plugins one by one (starting with javafx).
There is no more javafx, but I still have the blocking, but, skyper I am sorry, when I restart josm I do not have any stack trace

comment:9 Changed 15 months ago by leni

Component: Plugin javafxPlugin pt_assistant

I found the plugin that blocks my josm: it is pt_assistant.

Josm is not blocked anymore after removing pt_assistant and adding my previous plugins (which I removed) including javafx.

I do not know how to change the actions on the ticket.

Last edited 15 months ago by leni (previous) (diff)

comment:10 Changed 15 months ago by Klumbumbus

Cc: Biswesh darya giackserva added
Owner: changed from leni to team
Status: needinfonew

comment:11 Changed 15 months ago by leni

thanks Klumbumbus.

comment:12 in reply to:  9 Changed 15 months ago by skyper

Replying to leni:


I do not know how to change the actions on the ticket.

Usually, you can change it under "modify ticket".

comment:13 Changed 13 months ago by Polyglot

Sorry for being slow.

I opened the attached file in josm-latest.jar with the published version of PT_Assistant.

I tried to upload. I get the validation warnings screen and abort.

There are many stop_position nodes that are seemingly orphans. I select all of them and download their parent ways and relations.

I try to upload again. Now there are only 3 'orphans'.

I don't actually upload. Can't risk reverting those bus route relations to a situation of 3 months ago.

Unfortunately this also means I can't reproduce the issue.

Something similar was reported here: https://github.com/JOSM/pt_assistant/issues/31

For that case I did press the upload button, as I wasn't working with stale data. Couldn't reproduce that one either.

It would be good to know whether it's the validation screen that never appears, or whether it's after pressing the upload button.

comment:14 Changed 13 months ago by skyper

Owner: changed from team to leni
Status: newneedinfo

comment:15 Changed 13 months ago by leni

Owner: changed from leni to team
Status: needinfonew

It seems to have the same result, so I completed ...github/JOSM/pt_assistant/issues/31 in french, here is the same text in English:
I have a similar behaviour, but without split the way (another contributor pointed it out to me changing the colour)
I am on W10, JOSM 17013, pt_assistant 2.1.10-80-g7d9bba3
I download a bounding box: max lat 43.6650156 - min lon 1.374439 - max lon 1.3753617 - min lat 43.664449
In the list of Relations panel, I select the relation "transport scolaire - Collèges de Blagnac - Seilh S7111R01".
I add "description=test".
I upload the modification, nothing is displayed and josm freezes and I have to stop the task.

If I remove the plugin, when I upload, the window for sending the data is displayed and josm does not freeze.

If with the plugin, I download directly the relation at the start of josm, I add the same attribute, I send, the window with the messages of the validator is displayed and josm does not freeze.

leni

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to leni
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.