ClassNotFoundException at Mapillary

[GhostFoxSledgehammer]

What steps will reproduce the problem?

1. Upload Changeset using Sumbit Changeset button

What is the expected result?

Changes are bieng uploaded.

What happens instead?

ClassNotFoundException

I'm getting same error with both v.1.5.23 and my local build.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-06-02 08:27:29 +0200 (Tue, 02 Jun 2020)
Build-Date:2020-06-02 11:11:35
Revision:16538
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16538 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 248 MB / 989 MB (90 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) Client VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.23)
+ apache-commons (35362)
+ apache-http (35092)
+ javafx-windows (35458)
+ jna (35092)

Last errors/warnings:
- W: java.nio.file.FileSystemException: %UserProfile%\AppData\Local\Temp\josm_exec_powershell_7318431603355317571.txt: The process cannot access the file because it is being used by another process.
- W: Unable to request certificate of https://grca.nat.gov.tw
- W: java.nio.file.FileSystemException: %UserProfile%\AppData\Local\Temp\josm_exec_powershell_2908997586736377055.txt: The process cannot access the file because it is being used by another process.
- W: Unable to request certificate of https://grca.nat.gov.tw
- W: Region [userProfile_BLOCK_v2] : Problem verifying disk.
- E: Handled by bug report queue: java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory. Cause: java.lang.ClassNotFoundException: org.apache.commons.logging.LogFactory


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: Mapillary changeset upload (183)
java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory
	at org.apache.http.conn.ssl.DefaultHostnameVerifier.<init>(DefaultHostnameVerifier.java:82)
	at org.apache.http.impl.client.HttpClientBuilder.build(HttpClientBuilder.java:955)
	at org.openstreetmap.josm.plugins.mapillary.actions.MapillarySubmitCurrentChangesetAction.lambda$actionPerformed$0(MapillarySubmitCurrentChangesetAction.java:78)
	at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.logging.LogFactory
	at java.net.URLClassLoader.findClass(Unknown Source)
	at java.lang.ClassLoader.loadClass(Unknown Source)
	at org.openstreetmap.josm.plugins.PluginClassLoader.loadClass(PluginClassLoader.java:73)
	at java.lang.ClassLoader.loadClass(Unknown Source)
	... 4 more

[taylor.smock]

It looks like apache-http may actually depend upon apache-logging. You can work around this by adding it to plugin.requires in gradle.properties.

[taylor.smock]

Are you still having this issue?

[GhostFoxSledgehammer]

Replying to taylor.smock:

Are you still having this issue

Yes, I'm still getting this error when uploading changesets. Should I try to update something which might have fixed this?

[taylor.smock]

I don't think it has been fixed yet. I was wondering if it was still an issue for you. I'll attach an initial patch that may help (apply the patch to the apache-http plugin, then run ant clean dist install -- this should "just work (tm)" if you are not using ./gradlew runJosm).

[taylor.smock]

Convert to ivy for dependencies, instead of carrying a copy in the repository

[taylor.smock]

Add apache commons logging as an ivy dependency (for testing -- this patch SHOULD NOT be commited, since the commons logging should be in the apache-commons package)

[taylor.smock]

I've created a separate ticket for adding Apache Logging to either apache-commons or apache-http at #19562.