Modify

Opened 2 weeks ago

Closed 12 days ago

Last modified 12 days ago

#19403 closed enhancement (fixed)

Request to support new roles when validating route relations.

Reported by: pelderson@… Owned by: team
Priority: normal Milestone: 20.06
Component: Internal preset Version:
Keywords: Cc:

Description (last modified by simon04)

Five new roles have been approved for route relations. See osmwiki:Proposed_features/Recreational_route_relation_roles

The roles are: alternative, approach, excursion, connection, main.
No role is the same as main for data users, but the explicit value main is now an approved value.

Validation currently warns about roles other than forward, backward, and guidepost for members of route relations.

We would appreciate if the new role values could become accepted by the standard validation rules.

Attachments (1)

2020-06-21-200915.png (18.3 KB) - added by simon04 12 days ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 2 weeks ago by Klumbumbus

(Please don't set the milestone next time. Thats up to the JOSM team.)

comment:2 Changed 2 weeks ago by Klumbumbus

Component: Core validatorInternal preset

comment:3 Changed 2 weeks ago by pelderson@…

Of course. Sorry!

comment:4 Changed 2 weeks ago by skyper

forward/backward is missing for route relations in general.

comment:5 Changed 2 weeks ago by pelderson@…

Strange... the relation editor supports forward/backward roles for the continuity/way direction line display and when sorting. You would think validation would then also accept the roles!

comment:6 Changed 12 days ago by simon04

Description: modified (diff)

Currently, we have

         <role key="" text="route segment" requisite="required" type="way,closedway" member_expression="highway|route=ferry"/>
         <role key="" text="infrastructure" requisite="optional" type="node,closedway" member_expression="tourism OR amenity"/>
         <role key="" text="natural" requisite="optional" type="node,closedway" member_expression="natural=peak OR natural=volcano OR mountain_pass=yes OR natural=water OR tourism=viewpoint OR amenity=drinking_water OR natural=spring OR place=locality"/>
         <role key="guidepost" text="guidepost" requisite="optional" type="node" member_expression="information=guidepost"/>

Guidepost coming from osmwiki:Relation:route#Members

I'm waiting for an update of osmwiki:Tag:route%3Dhiking#Elements_of_a_relation. Currently, too much time for researching the status quo is needed (at least for me).

comment:7 Changed 12 days ago by pelderson@…

Updated. The roles are optional, and valid for route relations of types route=bicycle|canoe|foot|hiking|horse|inline_skates|mtb|running.
Note that the roles forward|backward were already in wide use for way members of these route relations (especially but not exclusively bicycle routes).

comment:8 Changed 12 days ago by simon04

I was hoping to see a nice table such as in osmwiki:Tag:route%3Dski#Members

comment:9 Changed 12 days ago by simon04

Resolution: fixed
Status: newclosed

In 16702/josm:

fix #19403 - Update recreational route relation roles


Last edited 12 days ago by simon04 (previous) (diff)

Changed 12 days ago by simon04

Attachment: 2020-06-21-200915.png added

comment:10 Changed 12 days ago by simon04

In 16703/josm:

see #19403 - Fix RelationCheckerTest.testHikingRouteMembers

comment:11 in reply to:  8 Changed 12 days ago by pelderson@…

Replying to simon04:

I was hoping to see a nice table such as in osmwiki:Tag:route%3Dski#Members


Wasn't this one in the proposal ok? https://wiki.openstreetmap.org/wiki/Proposed_features/Recreational_route_relation_roles#Tagging

comment:12 Changed 12 days ago by pelderson@…

Thanks for the quick response and fix!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.