Opened 4 years ago
Last modified 11 months ago
#20731 new defect
Relation checker doesn't accept role "main" and demands "<empty>" for route=hiking
Reported by: | Owned by: | team | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Internal preset | Version: | latest |
Keywords: | route role recreational relation | Cc: |
Description
What steps will reproduce the problem?
- add a relation of recreational type, according to:
https://wiki.openstreetmap.org/wiki/Roles_for_recreational_route_relations
with relations as members
- assign to a member the role "main"
- don't let any member without role
What is the expected result?
no warning is issued from validator
What happens instead?
Two warning of type "Role verification problem" are raised from the validator:
Role 'main' missing is not among expected values
Role '<empty>' missing
Please provide any additional information below. Attach a screenshot if possible.
Example of affected relation:
https://www.openstreetmap.org/relation/2178755
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-04-09 01:24:26 +0200 (Fri, 09 Apr 2021) Revision:17722 Build-Date:2021-04-09 01:30:57 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (17722 en_GB) Windows 10 64-Bit OS Build number: Windows 10 Home 1909 (18363) Memory Usage: 877 MB / 4068 MB (381 MB allocated, but free) Java version: 11.0.2+9-LTS, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 3840×2160 (scaling 2.50×2.50) Maximum Screen Size: 3840×2160 Best cursor sizes: 16×16→64×64, 32×32→64×64 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Dataset consistency test: No problems found Plugins: + Mapillary (1.5.37.3) + QuickLabel (18) + SimplifyArea (35640) + apache-commons (35524) + apache-http (35589) + editgpx (35562) + ejml (35458) + geotools (35458) + javafx-windows (35655) + jna (35662) + jts (35458) + measurement (35640) + merge-overlap (35640) + photo_geotagging (35715) + photoadjust (35640) + reltoolbox (35640) + reverter (35688) + rex (53) + undelete (35640) Tagging presets: + D:\OSM\JOSM\presets\cai_josm_preset-master\cai.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Mountains&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/CH.zip + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1 + https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip + https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1 Last errors/warnings: - 00056.137 E: Failed to locate image 'object--wire-group' - 00056.262 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1' - 00056.923 E: Failed to locate image 'regulatory--texts--g1' - 00056.924 E: Failed to locate image 'regulatory--texts--g2' - 00057.035 E: Failed to locate image 'void--car-mount' - 00057.036 E: Failed to locate image 'void--dynamic' - 00057.037 E: Failed to locate image 'void--ego-vehicle' - 00057.038 E: Failed to locate image 'void--ground' - 00057.040 E: Failed to locate image 'void--static' - 00057.235 E: Failed to locate image 'warning--kangaroo-crossing--g1'
Attachments (0)
Change History (7)
comment:1 by , 4 years ago
Component: | Core → Core validator |
---|---|
Summary: | Validator: Relation checker doesn't accept role "main", nor the lack of empty role → Relation checker doesn't accept role "main" nor "<empty>" for route=hiking |
comment:2 by , 4 years ago
comment:3 by , 4 years ago
Component: | Core validator → Internal preset |
---|---|
Keywords: | routes roles recreational added; Validator role removed |
comment:4 by , 4 years ago
Adding main
to the preset is little work but we should add a validator rule to check for at least one member with empty role or main
and maybe warn about a mix of both. Regarding other transport modes where all new roles are missing so far we will need some more rules as for/backward
is not allowed together with e.g. approach
.
comment:5 by , 3 years ago
Just recently found the attribute regexp=""
for <role />
which could be useful here.
comment:6 by , 3 years ago
Keywords: | route role relation added; routes roles removed |
---|---|
Summary: | Relation checker doesn't accept role "main" nor "<empty>" for route=hiking → Relation checker doesn't accept role "main" and demands "<empty>" for route=hiking |
comment:7 by , 11 months ago
Meanwhile, the recreational route's roles are present for hiking routes (where we do not use forward
and backward
) but they are missing for everything else, like route=bicycle
or route=canoe
.
Not very common roles according to https://taginfo.openstreetmap.org/relations/route#roles (4000 for role:main)
Role:main is a rather new invention according to https://wiki.openstreetmap.org/w/index.php?title=Role:main&action=history