Combine way: Instead of denying, offer help working outside downloaded area

[skyper]

This is a follow-up of #18083.

What steps will reproduce the problem?

1. Download a route relation without members
2. Download members through relation panel's context menu entry "Download members"
3. Select two ways with one end node in common
4. Download parents
5. Combine way

What is the expected result?

As all needed data is available, no warning about outside downloaded area and the usual procedure when combining ways with its dialogs about conflicting tags and relation memberships.

What happens instead?

The action is denied without any help to download missing data nor any option to continue without downloading.

Please provide any additional information below. Attach a screenshot if possible.

It would be sufficient to simply download the parents in prior, so why not offer this option?
At least in expert mode, there should be an option to continue without downloading as JOSM is not smart enough to detect that all possible information is available.

BTW: Why is this action call "Combine way" without a plural, e.g. ways.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-06-15 21:37:22 +0200 (Mon, 15 Jun 2020)
Revision:16649
Build-Date:2020-06-16 01:30:48
URL:https://josm.openstreetmap.de/svn/trunk

[GerdP]

Since #18083 I would expect the described behaviour but I cannot reproduce. Seems that #18083 is not yet fixed.
I tried relation 3341047 and I can combine members
w26701075 and w305195546
without any notification or popup :(

[GerdP]

The popup is only shown when you have a download area, the described steps don't download an area.

[skyper]

Strange, I always did work around it expecting the deny of action. What to do?

• Should I adjust the description to have a downloaded area?
• Should I change the ticket into a defect and follow-up of #18083 and the behavior is changed while fixing the bug?

[GerdP]

I think the notification should also be shown when there is no download area. Fixing that would be easy.
See also #17898 reg. automatic download of missing data. I thought I've commented somewhere that I got lost in complexity trying to find solutions in each action for you work flow without downoad areas. Cannot find it.

[skyper]

I remember problems with unity test or was it the roundabout/link_ problem?