Modify

Opened 4 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#19346 closed enhancement (fixed)

Automatically select newly created multipolygons

Reported by: tomasmarklund Owned by: GerdP
Priority: normal Milestone: 20.06
Component: Core Version:
Keywords: create multipolygon selection Cc: stoecker

Description (last modified by tomasmarklund)

When creating a multipolygon by selecting n number of ways and clicking ctrl-B, it would be very helpful if the newly created multipolygon was selected and the separate ways deselected.

Then I can easily add tags to the mp, either by addinge them manually, or using the presets.

Since presets are not possible to use from within the relations editor, i HAVE to select them in order to use the presets.

Attachments (0)

Change History (14)

comment:1 Changed 4 weeks ago by tomasmarklund

Summary: Automaically select newly created multipolygonsAutomatically select newly created multipolygons

comment:2 in reply to:  description ; Changed 4 weeks ago by skyper

Keywords: create multipolygon selection added

-1

If this is changed, please make it optional.

Replying to tomasmarklund:

When creating a multipolygon by selecting n number of ways and clicking ctrl-B, it would be very helpful if the newly created multipolygon also was selected.

The new relation is selected in relation list panel, so you have the option to open it directly in a relation editor or select it.

Then I can easily add tags to the mp, either by adding them manually, or using the presets.

Since presets are not possible to use from within the relations editor, i HAVE to select them in order to use the presets.

Presets should be available, as in Tags/Membership panel, with icons and links but you need to save the relation first with the source:trunk/resources/images/save.png button on the top if the relation was just created or if you did add/change the tag to match the preset. But you are right if you talk about MPs with only type= as tag.

comment:3 in reply to:  2 ; Changed 4 weeks ago by tomasmarklund

Replying to skyper:

The new relation is selected in relation list panel, so you have the option to open it directly in a relation editor or select it.

I know, but it is one extra right mouse button click, and then clicking "select relation" from the menu. Every time. Click-click. Every time you have to use the mouse to do something, time is lost.

Presets should be available, as in Tags/Membership panel, with icons and links but you need to save the relation first with the source:trunk/resources/images/save.png button on the top if the relation was just created or if you did add/change the tag to match the preset. But you are right if you talk about MPs with only type= as tag.

Yes, I can access the presets for already existing tags by clicking them as in Tags/Membership panel, but I can not add NEW tags in the relation editor by using presets. To be able to use presets to add tags to a relation (or anything), the relation needs to be selected first.

Counterquestion: How often, after using ctrl-B to create a MP from previously selected ways, do a user need to still have the separate ways selected? After all, they were selected only to create the MP. Not to be tagged separatly.

comment:4 in reply to:  3 Changed 4 weeks ago by skyper

Replying to tomasmarklund:

Replying to skyper:

The new relation is selected in relation list panel, so you have the option to open it directly in a relation editor or select it.

I know, but it is one extra right mouse button click, and then clicking "select relation" from the menu. Every time. Click-click. Every time you have to use the mouse to do something, time is lost.

So, you have the panel buttons disabled!?

Counterquestion: How often, after using ctrl-B to create a MP from previously selected ways, do a user need to still have the separate ways selected? After all, they were selected only to create the MP. Not to be tagged separately.

I often need to check if the correct tags where moved but for ways without tags I understand your request and the annoying mouse meters. So we need different treatments for (untagged) ways leading to MPs without tags but type.

comment:5 Changed 4 weeks ago by GerdP

I would not mind to change the selection to MP only when a new preference is set, but changing the current behaviour could confuse too many users. IMHO selecting the ways and "also" the MP would be the worst solution.
I would also agree to clear the selection if an MP was created, even without a new preference setting.

comment:6 in reply to:  5 Changed 4 weeks ago by tomasmarklund

Replying to skyper:

Replying to tomasmarklund:

So, you have the panel buttons disabled!?

I confess. I usually don't have the "relations" panel activated at all. I think the looong list of ALL relations loaded in my session is mostly confusing and uses screen space, but now I understand which button you mean. Nevertheless, it reduces "my" two clicks to one. But it is still one click..

I often need to check if the correct tags where moved but for ways without tags I understand your request and the annoying mouse meters. So we need different treatments for (untagged) ways leading to MPs without tags but type.

Note: not only untagged ways will lead to an untagged MP. If ways with different tags are preselected to create the MP, this will also lead to a MP with only the 'type' tag (which is the correct behavour).

comment:7 in reply to:  5 Changed 4 weeks ago by tomasmarklund

Replying to GerdP:

IMHO selecting the ways and "also" the MP would be the worst solution.

My initial case was unclear described. I did not mean "also" as in "I want BOTH the ways and the MP selected". I totally agree, to have BOTH the ways AND the MP selected would be more useless than ice skates in Sahara. I would like to clear the selection of the previously selected way(s), and instead have ONLY the newly created MP selected. Original text now updated.

Last edited 4 weeks ago by tomasmarklund (previous) (diff)

comment:8 Changed 4 weeks ago by tomasmarklund

Another analogy, just for fun.

*When I create a node, the node is automatically selected. I can immediately use presets (or enter tags manually) for the newly created node, I do not have to manually select the node first.

*When the above node is selected, and I create another node, a way is created, and the prevoiusly selected node is deselected. I can immediately use presets (or enter tags manually) for the newly created way, I do not have to manually select the way first.

*When the above way is selected, and I create a multipolygon (ctrl-b), the previously selected way is NOT deselected , and the MP is NOT selected. Here I have to manually select the newly created MP to be able to use presets for it (or enter tags manually).

I'd say this is not consistent. If "creating ways" were designed in the same way, after creating a way by click-clicl-clicking to create several nodes, all the nodes would still be selected, but not the way. That would not be fun at all...

comment:9 Changed 4 weeks ago by tomasmarklund

Description: modified (diff)

comment:10 Changed 4 weeks ago by GerdP

Cc: stoecker added
Owner: changed from team to GerdP
Status: newassigned

I agree that your suggested new behaviour would be fine, I just don't dare to change the old default behaviour unless we all agree that it was an error and thus should be changed.
@Dirk: What do you think?

comment:11 Changed 4 weeks ago by Klumbumbus

IMHO the suggested behavior by tomasmarklund to autoselect the MP after creation makes more sense as default behavior.

comment:12 Changed 4 weeks ago by GerdP

OK, I looked at the current code. I first thought that I just have to add one line of code, but it's a bit more complicated ;)
We already have a preference setting multipoly.show-relation-editor which is set to false by default. If set to true the Relation Editor is opened for the new relation with the ways are kept selected. I think this makes sense. Right?

The same code is also used when Update multipolygon action(Ctrl+Shift+B) is used. So, I tried what happens if
multipoly.show-relation-editor is set to true in combination with update and got a crash (see #19355).
My expected behaviour would be that the relation editor is opened with the updated relation and that the selection contains the previously selected way(s), but not the relation (if one was selected). Right?

I think I should first fix #19355, next I have to think about the various possible combinations of multipoly.show-relation-editor true or false, Ctrl+B or Ctrl+Shift+B used, and if the selected objects contain a multipolygon or a multipolygon member or just one or more ways.

comment:13 Changed 4 weeks ago by GerdP

Resolution: fixed
Status: assignedclosed

In 16557/josm:

fix #19346: Automatically select newly created multipolygons

  • if a new multipolygon relation is created, select the multipolygon only, but if preference multipoly.show-relation-editor is set to true keep the ways selected.
  • if Update multipolygon (Ctrl+Shift+B) is used, don't change the selection, but if preference multipoly.show-relation-editor is set to true remove the updated relation from the selection before opening the relation editor.

comment:14 Changed 4 weeks ago by Klumbumbus

Milestone: 20.06

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.