#19339 closed enhancement (duplicate)
Validator complains about Su,PH
| Reported by: | Owned by: | team | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | opening_hours holiday | Cc: |
Description
JOSM validator outputs for way 222036947, which has set
opening_hours="Jun: Mo-Sa 08:00-18:30; Jun: Su,PH 09:00-18:00"
TestError [tester=org.openstreetmap.josm.data.validation.tests.OpeningHourTest@51242aa6, code=2901, message=Opening hours syntax]
"Holiday after weekday at line 1, column 36"
Please improve this error message. Why is it a problem to have PH share the exact hours of a named weekday like Su?
Attachments (0)
Change History (3)
follow-up: 2 comment:1 by , 6 years ago
| Keywords: | opening_hours holiday added |
|---|---|
| Resolution: | → duplicate |
| Status: | new → closed |
| Type: | defect → enhancement |
follow-up: 3 comment:2 by , 6 years ago
Replying to skyper:
In a strict way,
PHneeds to be before<weekday>.
Is this a new rule? Even osmwiki:/Key:opening_hours lists as example: Mo-Su,PH 15:00-03:00; easter -2 days off
comment:3 by , 6 years ago
Replying to Klumbumbus:
Replying to skyper:
In a strict way,
PHneeds to be before<weekday>.
Is this a new rule? Even osmwiki:/Key:opening_hours lists as example:
Mo-Su,PH 15:00-03:00; easter -2 days off
No, it is a very old rule. We are just used to tag with the "relaxed" evaluation which is usually documented.
Your example above shows the other case, too, time span over midnight, which leads to a similar warning.
00:00-03:00,15:00-24:00; easter -2 days off would be the correct example in strict mode. If you want to add the days: PH,Mo-Su 00:00-03:00,15:00-24:00; easter -2 days off



Closed as duplicate of #18899.
In a strict way,
PHneeds to be before<weekday>. The setting for a more relaxed validation is missing so far.