Changes between Initial Version and Version 1 of Ticket #19269


Ignore:
Timestamp:
2020-05-21T00:17:24+02:00 (6 years ago)
Author:
simon04
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #19269

    • Property Milestone → 20.05
    • Property Owner changed from team to simon04
    • Property Status new → assigned

  • Ticket #19269 – Description

    initial v1  
    1 Adding tags via remote control is broken, e.g. in revision 16465.
     1Adding tags via remote control is broken, e.g. in revision r16465.
    22
    33When calling e.g.
     4{{{
    45/add_node?lon=13.3&lat=53.2&addtags=natural=tree|name=%20%20%20==Great%20Oak==
     6}}}
    57as mentioned in the help, the node is created at the right location, but the tags are not set, the tag dialog does not open.
    68
    7 This was broken by revision 16328, where AddTagsDialog.parseUrlTagsToKeyValues was changed to return Map<String, String> instead of String[][].  This makes AddTagsDialog.addTags(final Map<String, String> args,... call itself recursively, instead of calling AddTagsDialog.addTags(String[][] keyValue,... which would open the tags dialog.
     9This was broken by revision r16328, where `AddTagsDialog.parseUrlTagsToKeyValues` was changed to return `Map<String, String>` instead of `String[][]`.  This makes `AddTagsDialog.addTags(final Map<String, String> args,...` call itself recursively, instead of calling `AddTagsDialog.addTags(String[][] keyValue,...` which would open the tags dialog.
    810
    911While it is a good idea to use a Map for key/value paris principle, a Map does not keep the original order, as the formerly used array did.  The order might well-chosen, but would get lost in the current state of the code.