Modify

Opened 2 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#19269 closed defect (fixed)

Adding tags via remote control broken

Reported by: johsin18 Owned by: simon04
Priority: major Milestone: 20.05
Component: Core remotecontrol Version: latest
Keywords: regression Cc: simon04

Description (last modified by simon04)

Adding tags via remote control is broken, e.g. in revision r16465.

When calling e.g.

/add_node?lon=13.3&lat=53.2&addtags=natural=tree|name=%20%20%20==Great%20Oak==

as mentioned in the help, the node is created at the right location, but the tags are not set, the tag dialog does not open.

This was broken by revision r16328, where AddTagsDialog.parseUrlTagsToKeyValues was changed to return Map<String, String> instead of String[][]. This makes AddTagsDialog.addTags(final Map<String, String> args,... call itself recursively, instead of calling AddTagsDialog.addTags(String[][] keyValue,... which would open the tags dialog.

While it is a good idea to use a Map for key/value paris principle, a Map does not keep the original order, as the formerly used array did. The order might well-chosen, but would get lost in the current state of the code.

Attachments (0)

Change History (4)

comment:1 Changed 2 weeks ago by simon04

Description: modified (diff)
Milestone: 20.05
Owner: changed from team to simon04
Status: newassigned

comment:2 Changed 2 weeks ago by simon04

Resolution: fixed
Status: assignedclosed

In 16471/josm:

fix #19269 - Remote control: addtags= broken

Regression of r16328.

comment:3 Changed 2 weeks ago by simon04

In 16472/josm:

see #19269 - TextTagParser.readTagsByRegexp: retain order of tags when parsing

comment:4 Changed 2 weeks ago by simon04

Thanks for noticing and reporting this issue!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.