﻿id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
19269	Adding tags via remote control broken	johsin18	simon04	"Adding tags via remote control is broken, e.g. in revision r16465.

When calling e.g.
{{{
/add_node?lon=13.3&lat=53.2&addtags=natural=tree|name=%20%20%20==Great%20Oak==
}}}
as mentioned in the help, the node is created at the right location, but the tags are not set, the tag dialog does not open.

This was broken by revision r16328, where `AddTagsDialog.parseUrlTagsToKeyValues` was changed to return `Map<String, String>` instead of `String[][]`.  This makes `AddTagsDialog.addTags(final Map<String, String> args,...` call itself recursively, instead of calling `AddTagsDialog.addTags(String[][] keyValue,...` which would open the tags dialog.

While it is a good idea to use a Map for key/value paris principle, a Map does not keep the original order, as the formerly used array did.  The order might well-chosen, but would get lost in the current state of the code."	defect	closed	major	20.05	Core remotecontrol	latest	fixed	regression	simon04
