Opened 6 years ago
Last modified 6 years ago
#19269 closed defect
Adding tags via remote control broken — at Initial Version
| Reported by: | johsin18 | Owned by: | team |
|---|---|---|---|
| Priority: | major | Milestone: | 20.05 |
| Component: | Core remotecontrol | Version: | latest |
| Keywords: | regression | Cc: | simon04 |
Description
Adding tags via remote control is broken, e.g. in revision 16465.
When calling e.g.
/add_node?lon=13.3&lat=53.2&addtags=natural=tree|name=%20%20%20==Great%20Oak==
as mentioned in the help, the node is created at the right location, but the tags are not set, the tag dialog does not open.
This was broken by revision 16328, where AddTagsDialog.parseUrlTagsToKeyValues was changed to return Map<String, String> instead of String[][]. This makes AddTagsDialog.addTags(final Map<String, String> args,... call itself recursively, instead of calling AddTagsDialog.addTags(String[][] keyValue,... which would open the tags dialog.
While it is a good idea to use a Map for key/value paris principle, a Map does not keep the original order, as the formerly used array did. The order might well-chosen, but would get lost in the current state of the code.
