Modify

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#19254 closed enhancement (fixed)

History browser: double click relation member table to open history of member

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.05
Component: Core Version:
Keywords: history browser Cc:

Description


Attachments (0)

Change History (13)

comment:1 Changed 6 months ago by simon04

Resolution: fixed
Status: assignedclosed

In 16459/josm:

fix #19254 - History browser: double click relation member table to open history of member

comment:2 Changed 6 months ago by GerdP

Resolution: fixed
Status: closedreopened

Good idea, but doesn't work for me. I see in the log that the history of a way is downloaded but there is no corresponding dialog. Instead the view changes from member list to tags for the relation history dialog where I double clicked the member.
Try relation 148838 with double click on member 445220771 (top in v614).
It seems to work when I click on a node in the history for a way, but that also changes the view back to the initial tags view.

comment:3 Changed 6 months ago by GerdP

See also org.openstreetmap.josm.gui.dialogs.changeset.ChangesetContentPanel.ShowHistoryAction

comment:4 Changed 6 months ago by GerdP

Found a few more problems:

  • double click on first row is ignored (<= 0 should be < 0)
  • javadoc is wrong

Working on a patch ...

comment:5 Changed 6 months ago by GerdP

In 16460/josm:

see #19254

  • double click on first row did not work
  • allow to use all implementations of PrimitiveId in HistoryDataSet.getHistory()
  • simplify code, correct javadoc

comment:6 Changed 6 months ago by GerdP

Resolution: fixed
Status: reopenedclosed

comment:7 Changed 6 months ago by GerdP

We have now three implementations of a ShowHistoryAction, all more or less doing the same. I am sure this can be simplified.
See #19257

Last edited 6 months ago by GerdP (previous) (diff)

comment:8 Changed 6 months ago by GerdP

Resolution: fixed
Status: closedreopened

The original dialog still switches the view to the tags panel. No idea why.

comment:9 in reply to:  7 Changed 6 months ago by simon04

Thanks for addressing the issues you found!

Replying to GerdP:

We have now three implementations of a ShowHistoryAction.

I haven't added one, but just moved it. *washing my hands of responsibility* :-)
A harmonization is very welcome.

comment:10 in reply to:  8 ; Changed 6 months ago by GerdP

Replying to GerdP:

The original dialog still switches the view to the tags panel. No idea why.

I tried to find the code point where this happens but failed. It is not related to this ticket, same problem occurs when you select a different object and press Ctrl+H.

comment:11 Changed 6 months ago by GerdP

Resolution: fixed
Status: reopenedclosed

comment:12 in reply to:  10 ; Changed 6 months ago by skyper

Replying to GerdP:

Replying to GerdP:

The original dialog still switches the view to the tags panel. No idea why.

I tried to find the code point where this happens but failed. It is not related to this ticket, same problem occurs when you select a different object and press Ctrl+H.

Still present and annoying as it can complete break the workflow. ATM, only a feature under certain circumstances but a bug in other situations.

comment:13 in reply to:  12 Changed 6 months ago by GerdP

Replying to skyper:

Replying to GerdP:

Replying to GerdP:

The original dialog still switches the view to the tags panel. No idea why.

I tried to find the code point where this happens but failed. It is not related to this ticket, same problem occurs when you select a different object and press Ctrl+H.

Still present and annoying as it can complete break the workflow. ATM, only a feature under certain circumstances but a bug in other situations.

Fixed in #19367

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.