Modify

Opened 8 weeks ago

Last modified 8 weeks ago

#19236 new task

checkstyle complains about CRLF in plugin sources

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

I wonder if this is intended? It complains about many old sources in the plugins:

<checkstyle version="8.31">
<file name="C:\josm\plugins\pbf\src\org\openstreetmap\josm\plugins\pbf\PbfConstants.java">
<error line="1" severity="warning" message="Das erwartete Zeilenende für die Datei ist LF(\n), aber CRLF(\r\n) wird erkannt." source="com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck"/>
</file>

CRLF in core sources don't produce the message.

Attachments (0)

Change History (4)

comment:1 Changed 8 weeks ago by stoecker

Should probably fixed everywhere. core also shouldn't have \r. And also no tab stops.

comment:2 Changed 8 weeks ago by GerdP

1600 of 1803 java sources in core have CRLF.

comment:3 in reply to:  2 Changed 8 weeks ago by stoecker

Replying to GerdP:

1600 of 1803 java sources in core have CRLF.

Only on windows.

grep -P '\r' -r . -l|wc -l

65

These are the ones not marked properly.

comment:4 Changed 8 weeks ago by GerdP

Maybe. I searched for *.java files containing 0x0d0x0a.
My other project (mkgmap) has an svn upload hook which rejects sources with CRLF, so I am used to work with unix style files. I thought that I configured svn to check out files "as is".

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to GerdP
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.