Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#19222 closed defect (fixed)

Wikipedia PluginException

Reported by: gaben Owned by: floscher
Priority: normal Milestone:
Component: Plugin wikipedia Version: latest
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Download data with overpass
  2. Wait until query finishes

What is the expected result?

The query finishing without disruption.

What happens instead?

Exception shows up.

Please provide any additional information below. Attach a screenshot if possible.

#19221 could be related, both have issues with caching.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-05-10 15:58:34 +0200 (Sun, 10 May 2020)
Build-Date:2020-05-11 01:30:50
Revision:16402
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16402 hu) Windows 10 64-Bit
OS Build number: Windows 10 Pro for Workstations 1909 (18363)
Memory Usage: 1062 MB / 1820 MB (527 MB allocated, but free)
Java version: 1.8.0_251-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1200
Maximum Screen Size: 1920x1200
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\31\583aa85f-404a7071, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=55329, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ apache-commons (35362)
+ continuosDownload (91)
+ ejml (35313)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ opendata (35405)
+ pt_assistant (2.1.10-79-gb14a159)
+ reverter (35409)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ utilsplugin2 (35434)
+ wikipedia (1.1.3)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- E: Region [TMS_BLOCK_v2] : Problem loading keys for file TMS_BLOCK_v2
- E: java.lang.reflect.InvocationTargetException. Indok: java.lang.NoSuchMethodError: org.openstreetmap.josm.data.cache.JCSCacheManager.getCache(Ljava/lang/String;IILjava/lang/String;)Lorg/apache/commons/jcs/access/CacheAccess;
- E: Handled by bug report queue: org.openstreetmap.josm.plugins.PluginException: A(z) wikipedia bővítményben hiba történt. Indok: java.lang.reflect.InvocationTargetException. Indok: java.lang.NoClassDefFoundError: Could not initialize class org.wikipedia.Caches
- W: Figyelmeztetés - <html>A JOSM nem talált információt az alábbi bővítményekről:<ul><li>apache-commons</li><li>geotools</li><li>tageditor</li><li>opendata</li><li>jts</li><li>ejml</li><li>reverter</li><li>continuosDownload</li><li>jaxb</li><li>pt_assistant</li><li>turnlanes-tagging</li><li>utilsplugin2</li><li>OpeningHoursEditor</li><li>wikipedia</li></ul>A bővítmények nem lesznek betöltve.</html>


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (59) of javawsApplicationThreadGroup
org.openstreetmap.josm.plugins.PluginException: A(z) wikipedia bővítményben hiba történt
	at org.openstreetmap.josm.plugins.PluginProxy.handlePluginException(PluginProxy.java:60)
	at org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:71)
	at org.openstreetmap.josm.gui.MainPanel.updateContent(MainPanel.java:80)
	at org.openstreetmap.josm.gui.MainPanel$1.beforeFirstLayerAdded(MainPanel.java:157)
	at org.openstreetmap.josm.gui.layer.MainLayerManager.realAddLayer(MainLayerManager.java:281)
	at org.openstreetmap.josm.gui.layer.LayerManager.lambda$addLayer$0(LayerManager.java:217)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWaitWithException(GuiHelper.java:239)
	at org.openstreetmap.josm.gui.layer.LayerManager.addLayer(LayerManager.java:217)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$AbstractInternalTask.addNewLayerIfRequired(DownloadOsmTask.java:356)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$AbstractInternalTask.loadData(DownloadOsmTask.java:363)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$DownloadTask.finish(DownloadOsmTask.java:509)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.WaitDispatchSupport$2.run(Unknown Source)
	at java.awt.WaitDispatchSupport$4.run(Unknown Source)
	at java.awt.WaitDispatchSupport$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.WaitDispatchSupport.enter(Unknown Source)
	at java.awt.Dialog.show(Unknown Source)
	at java.awt.Component.show(Unknown Source)
	at java.awt.Component.setVisible(Unknown Source)
	at java.awt.Window.setVisible(Unknown Source)
	at java.awt.Dialog.setVisible(Unknown Source)
	at org.openstreetmap.josm.gui.progress.swing.PleaseWaitProgressMonitor.lambda$doBeginTask$3(PleaseWaitProgressMonitor.java:255)
	at org.openstreetmap.josm.gui.progress.swing.PleaseWaitProgressMonitor.lambda$doInEDT$0(PleaseWaitProgressMonitor.java:113)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:66)
	... 46 more
Caused by: java.lang.NoClassDefFoundError: Could not initialize class org.wikipedia.Caches
	at org.wikipedia.api.ApiQueryClient.query(ApiQueryClient.java:40)
	at org.wikipedia.WikipediaApp.<init>(WikipediaApp.java:58)
	at org.wikipedia.WikipediaApp.forLanguage(WikipediaApp.java:71)
	at org.wikipedia.gui.WikipediaToggleDialog.newWikipediaApp(WikipediaToggleDialog.java:162)
	at org.wikipedia.gui.WikipediaToggleDialog.updateTitle(WikipediaToggleDialog.java:144)
	at org.wikipedia.gui.WikipediaToggleDialog.<init>(WikipediaToggleDialog.java:88)
	at org.wikipedia.WikipediaPlugin.mapFrameInitialized(WikipediaPlugin.java:72)
	... 51 more

Attachments (0)

Change History (12)

comment:1 by gaben, 5 years ago

Component: CorePlugin wikipedia
Owner: changed from team to floscher

comment:3 by taylor.smock, 5 years ago

See #19208.

I've made a pull request for it at https://github.com/JOSM/wikipedia/pull/4 .

in reply to:  3 comment:4 by gaben, 5 years ago

As far as I know, the plugin is maintained primarily at GitLab: https://gitlab.com/JOSM/plugin/wikipedia

comment:6 by mdk, 5 years ago

https://gitlab.com/JOSM/plugin/wikipedia contains in gradle.properties (last update 5 months ago)

plugin.main.version = 14149
plugin.compile.version = 15492

https://github.com/JOSM/wikipedia refer to newer JOSM versions (last update 2 days ago)

plugin.main.version = 16398
plugin.compile.version = 16402

And PluginsSource refers to

​https://josm.gitlab.io/plugin/wikipedia/dist/latest/wikipedia.jar

But ​https://josm.gitlab.io/plugin/wikipedia refers to both repositories. And there are also links to releases:

Last release on GitLab is 1.1.3 (2019-11-24) see https://gitlab.com/JOSM/plugin/wikipedia/-/releases
Last release on GitHub is 1.1.1 (2018-09-19) see https://github.com/JOSM/wikipedia/releases

GitHub has the latest changes, but no release since 2018.

comment:7 by simon04, 5 years ago

I cannot push to GitLab

$ git push gitlab master
...
remote: GitLab: You are not allowed to push code to protected branches on this project.
To gitlab.com:JOSM/plugin/wikipedia.git
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'git@gitlab.com:JOSM/plugin/wikipedia.git'

comment:8 by simon04, 5 years ago

Ticket #19229 has been marked as a duplicate of this ticket.

comment:9 by simon04, 5 years ago

floscher, thanks for giving me access to the GitLab repository!

I've tried to release a new version – https://gitlab.com/JOSM/plugin/wikipedia/-/tags/v1.1.4
The CI/CD step package to GitLab.com failed – https://gitlab.com/JOSM/plugin/wikipedia/-/jobs/553258439

in reply to:  9 comment:10 by floscher, 5 years ago

Replying to simon04:

floscher, thanks for giving me access to the GitLab repository!

I've tried to release a new version – https://gitlab.com/JOSM/plugin/wikipedia/-/tags/v1.1.4
The CI/CD step package to GitLab.com failed – https://gitlab.com/JOSM/plugin/wikipedia/-/jobs/553258439

No problem, sorry for the delay to creating a new release. I now fixed the release process and published v1.1.4.

Tip: When tagging a release in git, use an annotated tag (command line option -a, or -s if you even want to sign the tag with PGP). Then you can attach a meaningful release message to the tag. This kind of tag is recommended for releases, the lightweight tag type is more intended as temporary markers.
Also, when the gradle-josm-plugin determines the version number, it takes only the annotated tags into account.

This wasn't the problem with the CI job, there an environment variable was not available in the job. It might have been the case that we got into each others way when I modified the settings for protected tags, which probably disabled the environment variable.

comment:11 by floscher, 5 years ago

Resolution: fixed
Status: newclosed

comment:12 by simon04, 5 years ago

@floscher, thank you for fixing the CI/CD issue and releasing a new version of the wikipedia plugin!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain floscher.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.