Modify

Opened 2 months ago

Closed 4 weeks ago

#19138 closed defect (fixed)

[Patch] Warn when you try to delete a node which is part of a way which is hidden by a filter

Reported by: Klumbumbus Owned by: GerdP
Priority: normal Milestone: 20.06
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

Delete a node which is part of a way which is hidden by a filter

What is the expected result?

A warning appears

What happens instead?

The node is deleted from the hidden way, thus the way is modified

Please provide any additional information below. Attach a screenshot if possible.

We already have a warning if you move the node. Deleting usually has even more impact.
from https://forum.openstreetmap.org/viewtopic.php?pid=784079#p784079

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-21 08:13:51 +0200 (Tue, 21 Apr 2020)
Build-Date:2020-04-22 01:30:47
Revision:16372
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16372 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 857 MB / 1820 MB (273 MB allocated, but free)
Java version: 1.8.0_251-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=54189, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Attachments (1)

19138.patch (2.4 KB) - added by GerdP 6 weeks ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 weeks ago by GerdP

Owner: changed from team to GerdP
Status: newassigned

Changed 6 weeks ago by GerdP

Attachment: 19138.patch added

comment:2 Changed 6 weeks ago by GerdP

Milestone: 20.05
Summary: Warn when you try to delete a node which is part of a way which is hidden by a filter[Patch] Warn when you try to delete a node which is part of a way which is hidden by a filter

comment:3 Changed 5 weeks ago by simon04

Milestone: 20.0520.06

comment:4 Changed 4 weeks ago by GerdP

Resolution: fixed
Status: assignedclosed

In 16558/josm:

fix #19138: Warn when you try to delete a node which is part of a way which is hidden by a filter

  • add check and dialog similar to that which is done when a node is moved

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.