Unglue node may not warn for all related relations

[GerdP]

What steps will reproduce the problem?

1. load attached sample file
2. select node where roads cross
3. Press G to unglue
4. Press Enter in the popup to accept the defaults

What is the expected result?

Warning notification that two relations were possibly changed

What happens instead?

Warning notification "Unglueing affected 1 relation"

Please provide any additional information below. Attach a screenshot if possible.

Happens when there are multiple relations with the same restriction tag, e.g. restriction=only_straight_on using the unglued node as via node and the look & feel is not configured to show ids or the relations are new.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 02:17:07 +0200 (Mon, 06 Apr 2020)
Build-Date:2020-04-06 00:18:43
Revision:16239
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16239 de) Windows 10 64-Bit
OS Build number: Windows 10 Home 1903 (18362)
Memory Usage: 363 MB / 1820 MB (198 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20200417_090402.jfr]
Dataset consistency test: No problems found

[GerdP]

I am not yet sure how to fix this. The error is that the names of the relations are collected in a Set and thus duplicate names are removed. I think we should always show the unique ids of the relations in this notification or maybe simply select them all?

[GerdP]

In 16362/josm:

see #19111, #19105

• don't ignore/reverse user input given in popup reg. tags/memberships
• report correct number of affected relations (#19105)
• when unglued (old) node is moved, place it either at the current mouse position (in cursor is in mapview) or 5 pixels above the original position. The old code sometimes placed it somewhere near the edge of the mapview window. The actual position depends on the input device that is used to select the node and to close the popup dialog (keyboard or mouse)
• various code simplifications

[GerdP]

TODO: relations might not be known when

• no download area exists
• user confirmed that the action should be performed although the unglued node is not inside a download area

[GerdP]

In 16363/josm:

see #19111, #19105
revert one last minute change: if only a way is selected, use all nodes in checkAndConfirmOutlyingUnglue()

[GerdP]

Problems mentioned in comment:4 might be handled in other tickets, e.g. #18959

[Klumbumbus]

Milestone renamed