Modify

Opened 8 months ago

Closed 8 months ago

Last modified 7 months ago

#19104 closed defect (fixed)

Unglue node may remove way members from relations

Reported by: GerdP Owned by: GerdP
Priority: normal Milestone: 20.05
Component: Core Version:
Keywords: template_report Cc:

Description (last modified by GerdP)

What steps will reproduce the problem?

  1. load attached file
  2. open the route relation in relation editor, note that the same node appears twice in the relation
  3. select that node and press G to unglue
  4. select "Old node" for tags, "New node" for the membership
  5. refresh relation editor data

What is the expected result?

same way members in the relation, old node not in relation, new nodes in the relation

What happens instead?

one way member is removed, old node is still in the relation

Please provide any additional information below. Attach a screenshot if possible.

Probably a very theoretical error, just noticed it while looking at the code in UnglueAction.updateMemberships()

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 02:17:07 +0200 (Mon, 06 Apr 2020)
Build-Date:2020-04-06 00:18:43
Revision:16239
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16239 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1903 (18362)
Memory Usage: 1029 MB / 1820 MB (252 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20200417_062009.jfr]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ PolygonCutOut (v0.7)
+ apache-commons (35362)
+ buildings_tools (35405)
+ continuosDownload (91)
+ ejml (35313)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ merge-overlap (35248)
+ o5m (35248)
+ opendata (35405)
+ pbf (35248)
+ poly (35248)
+ reverter (35409)
+ undelete (35405)
+ utilsplugin2 (35405)

Validator rules:
+ c:\josm\core\resources\data\validator\geometry.mapcss

Last errors/warnings:
- W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>

Attachments (1)

19104-sample.osm (1.8 KB) - added by GerdP 8 months ago.

Download all attachments as: .zip

Change History (6)

Changed 8 months ago by GerdP

Attachment: 19104-sample.osm added

comment:1 Changed 8 months ago by GerdP

Description: modified (diff)
Owner: changed from team to GerdP
Status: newassigned

comment:2 Changed 8 months ago by GerdP

Description: modified (diff)

comment:3 Changed 8 months ago by GerdP

Resolution: fixed
Status: assignedclosed

In 16317/josm:

fix #19104: Unglue node may remove way members from relations

  • fix and simplify update of relations

comment:4 Changed 7 months ago by GerdP

Milestone: 20.04

comment:5 Changed 7 months ago by Klumbumbus

Milestone: 20.0420.05

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.