Modify

Opened 5 years ago

Closed 5 years ago

#19076 closed enhancement (fixed)

Changing value of curves.circlearc.angle-separation value in advanced preferences no longer appears to have any effect.

Reported by: ethnicfoodisgreat@… Owned by: GerdP
Priority: normal Milestone:
Component: Plugin utilsplugin2 Version: latest
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Access Advanced Preferences.
  2. I changed the value of curves.circlearc.angle-separation value to 1. Save changes.
  3. Draw a line with three nodes and then press Shift-C to draw a curve connecting the nodes.

What is the expected result?

It used to produce a curve where the angle separation between the nodes was 1 degree.

What happens instead?

It produces a curve with the default separation angle. (I believe it is 20.)

Please provide any additional information below. Attach a screenshot if possible.

In the attached screenshot, the original line is on the left and the result of the Shift-C
command is on the right. It used to produce a much smoother curve with more nodes and only
one angular degree of separation between them.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 02:17:07 +0200 (Mon, 06 Apr 2020)
Build-Date:2020-04-06 00:18:43
Revision:16239
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16239 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 1825 MB / 7271 MB (629 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1440x900, \Display1 1440x900, \Display2 1920x1200, \Display3 1920x1200
Maximum Screen Size: 1920x1200
Dataset consistency test: No problems found

Plugins:
+ apache-commons (35362)
+ ejml (35313)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ log4j (35092)
+ opendata (35405)
+ reverter (35409)
+ tageditor (35258)
+ undelete (35405)
+ utilsplugin2 (35405)

Tagging presets:
+ D:\Downloads\JOSM\Mark's presets.xml

Map paint styles:
+ D:\Downloads\JOSM\My_style.mapcss

Last errors/warnings:
- W: Update plugins - You updated your JOSM software. To prevent problems the plugins should be updated as well.  Update plugins now?
- W: No default layer selected, choosing first layer.

Attachments (1)

JOSM example.png (61.9 KB ) - added by ethnicfoodisgreat@… 5 years ago.
Screenshot showing result of Shift-C command.

Download all attachments as: .zip

Change History (10)

by ethnicfoodisgreat@…, 5 years ago

Attachment: JOSM example.png added

Screenshot showing result of Shift-C command.

comment:1 by GerdP, 5 years ago

The preference key is longer evaluated, see ticket:18847#comment:8 and following.

Last edited 5 years ago by GerdP (previous) (diff)

comment:2 by GerdP, 5 years ago

Owner: changed from team to ethnicfoodisgreat@…
Status: newneedinfo

I think it works well for small and large circles. Do you have a special need for more "smoothness"?

comment:3 by ethnicfoodisgreat@…, 5 years ago

Hi Gerd. No, I do not have a special need for smoother curves. I just like the look of them. Although I know some people don't like the fact it consumes more space in the database and increases display time. But if the setting is no longer honored, why not remove it?

comment:4 by GerdP, 5 years ago

Owner: changed from ethnicfoodisgreat@… to GerdP
Status: needinfoassigned
Type: defectenhancement

Good question. I've removed the documentation in the wiki but I never thought about removing the preference setting.
I'll have a look tomorrow.

comment:5 by anonymous, 5 years ago

Ok.

comment:6 by skyper, 5 years ago

You can still create a big circle/curve and shrink it.

comment:7 by ethnicfoodisgreat@…, 5 years ago

Right.

comment:8 by GerdP, 5 years ago

In 16297/josm:

see #18847, #19076: Changing value of curves.circlearc.angle-separation value in advanced preferences no longer appears to have any effect.

  • add curves.circlearc.angle-separation to the list of obsolete preference keys

comment:9 by GerdP, 5 years ago

Component: CorePlugin utilsplugin2
Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.