Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#19069 closed defect (fixed)

Validator message doesn't display values from selectors with regexp anymore

Reported by: Klumbumbus Owned by: team
Priority: major Milestone: 20.05
Component: Core Version:
Keywords: template_report regression Cc: simon04

Description (last modified by Klumbumbus)

What steps will reproduce the problem?

valildate a node tagged with parking=surface only

What is the expected result?

missing tag - parking without amenity=parking|parking_space|parking_entrance|motorcycle_parking

What happens instead?

missing tag - parking without amenity=

Please provide any additional information below. Attach a screenshot if possible.

This is a regression of r15990. Simply revert that change?

The rule in combinations.mapcss is

*[parking                      ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/][parking!=yes][parking!=no],
way[cutline                    ][man_made!=cutline],
*[bunker_type                  ][military!=bunker] {
  throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
  group: tr("missing tag");
}
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-10 19:22:21 +0200 (Fri, 10 Apr 2020)
Build-Date:2020-04-11 01:30:44
Revision:16251
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16251 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 1031 MB / 1820 MB (605 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=62702, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Attachments (0)

Change History (5)

comment:1 by GerdP, 5 years ago

I see the expected "missing tag - parking without amenity="

comment:2 by Klumbumbus, 5 years ago

Description: modified (diff)

Sorry I mixed it up "What is the expected result?" and "What happens instead?" Fixed the description.

comment:3 by GerdP, 5 years ago

This is a regression of r15990. Simply revert that change?

+1

comment:4 by Klumbumbus, 5 years ago

Resolution: fixed
Status: newclosed

In 16287/josm:

see #18802, fix #19069 - Restore display of values from selectors with regexp in validator messages

comment:5 by Klumbumbus, 5 years ago

Milestone: 20.0420.05

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.