Modify

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#19065 closed task (fixed)

Ant: write REVISION to resources/

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.05
Component: Core Version:
Keywords: ant revision resources Cc:

Description

CONTRIBUTION, REVISION, README, LICENSE are additional resource files.

For an easier IDE setup (IntelliJ), those files should be copied/written to the resources/ directory.

Vincent, can I apply the following patch?

  • build.xml

    diff --git a/build.xml b/build.xml
    index 77a24027c..794f1f1b9 100644
    a b  
    160160      ** Creates the REVISION file to be included in the distribution
    161161    -->
    162162    <target name="create-revision" depends="init-properties,init-svn-revision-xml,init-git-revision-xml">
    163         <property name="revision.dir" value="${build.dir}"/>
     163        <copy todir="${resources.dir}">
     164            <file file="CONTRIBUTION"/>
     165            <file file="README"/>
     166            <file file="LICENSE"/>
     167        </copy>
    164168        <xmlproperty file="${base.dir}/REVISION.XML" prefix="version" keepRoot="false" collapseAttributes="true"/>
    165169        <delete file="${base.dir}/REVISION.XML"/>
    166170        <tstamp>
     
    168172        </tstamp>
    169173        <property name="version.entry.commit.revision" value="UNKNOWN"/>
    170174        <property name="version.entry.commit.date" value="UNKNOWN"/>
    171         <mkdir dir="${revision.dir}"/>
    172175        <!-- add Build-Name: ... when making special builds, e.g. DEBIAN -->
    173         <echo file="${revision.dir}/REVISION">
     176        <echo file="${resources.dir}/REVISION">
    174177# automatically generated by JOSM build.xml - do not edit
    175178Revision: ${version.entry.commit.revision}
    176179Is-Local-Build: true
    Build-Date: ${build.tstamp}  
    188191    <!--
    189192      ** Main target that builds JOSM and checks XML against schemas
    190193    -->
    191     <target name="dist" depends="compile,extract-libraries,epsg,copy-resources,create-revision,check-schemas">
     194    <target name="dist" depends="compile,extract-libraries,epsg,create-revision,copy-resources,check-schemas">
    192195        <echo>Revision ${version.entry.commit.revision}</echo>
    193         <copy file="CONTRIBUTION" todir="${build.dir}"/>
    194         <copy file="README" todir="${build.dir}"/>
    195         <copy file="LICENSE" todir="${build.dir}"/>
    196196        <!-- create josm-custom.jar -->
    197197        <delete file="${dist.jar}"/>
    198198        <jar destfile="${dist.jar}" basedir="${build.dir}" level="${clevel}">

Attachments (0)

Change History (4)

comment:1 by taylor.smock, 6 years ago

This also affects Eclipse, not just IntelliJ (I had been wondering why I was suddenly on an unknown JOSM version, when building/testing features).

comment:2 by simon04, 6 years ago

Owner: changed from team to simon04
Status: newassigned

comment:3 by simon04, 6 years ago

Resolution: fixed
Status: assignedclosed

In 16349/josm:

fix #19065, see #19117 - ant create-revision: write to resources/

comment:4 by Klumbumbus, 5 years ago

Milestone: 20.0420.05

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.