Modify

Opened 2 months ago

Closed 8 weeks ago

Last modified 4 weeks ago

#19022 closed enhancement (fixed)

Tagging presets: More flexible "preset_link"

Reported by: skyper Owned by: team
Priority: normal Milestone: 20.05
Component: Core Version:
Keywords: template_report tagging preset link Cc:

Description (last modified by skyper)

  • I would like to be able to place a link everywhere in the preset and not just at the bottom
  • Additionally, I would like to change the text similar to <optional>

What steps will reproduce the problem?

  1. Have a <preset_link preset_name="Tower" text="DESCRIPTION" inline="true" \> at the top of an <item>
  2. Additional have a <preset_link preset_name="Address" \> at the bottom of the item

What is the expected result?

  • A <label \> with text="DESCRIPTION" and link to "Tower" preset at top.
  • The link to "Address" preset with default label at the bottom

What happens instead?

Both links at the bottom (text and inline fictional)

Please provide any additional information below. Attach a screenshot if possible.

I tried to work with it but failed. See screenshot and code below. Look at the label on top with missing link.

screenshot of broken preset

  <item name="Big Communication Tower" icon="presets/landmark/Communication_tower-14.svg" type="node,closedway,multipolygon" preset_name_label="true">
      <link wiki="Tag:man_made=communications_tower" />
      <space />
      <label text="Big communication tower, usually over 100 meters high." />
      <label text="Use Tower for smaller ones:" />
      <preset_link preset_name="Tower" />
      <space />
      <key key="man_made" value="communications_tower" />
      <multiselect key="tower:type" text="Type of tower" values_sort="false" default="communication" rows="3">
          <list_entry value="communication" display_value="Communication tower" icon="presets/landmark/Tower_cantilever_communication.svg" />
          <list_entry value="watchtower" display_value="Watch tower" icon="presets/landmark/Tower_observation.svg" />
      </multiselect>
      <reference ref="tower_construct" />
      <reference ref="optional_public_building" />
      <preset_link preset_name="Contact (Common Schema)" />
      <preset_link preset_name="Address" />
  </item> <!-- Big Communication Tower -->
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-31 20:51:44 +0200 (Tue, 31 Mar 2020)
Revision:16222
Build-Date:2020-04-01 01:30:45
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (2)

josm_presetLink_problem.png (46.6 KB) - added by skyper 2 months ago.
screenshot of broken preset
2020-04-12-220945_348x534_scrot.png (15.1 KB) - added by simon04 8 weeks ago.

Download all attachments as: .zip

Change History (10)

Changed 2 months ago by skyper

Attachment: josm_presetLink_problem.png added

screenshot of broken preset

comment:1 Changed 2 months ago by skyper

Description: modified (diff)

comment:2 Changed 8 weeks ago by simon04

Resolution: fixed
Status: newclosed

In 16280/josm:

fix #19022 - PresetLink: allow to customize label text and UI position

Changed 8 weeks ago by simon04

comment:3 Changed 8 weeks ago by simon04

Milestone: 20.04
        <item name="Hotel" icon="presets/accommodation/hotel.svg" type="node,closedway,multipolygon" preset_name_label="true">
            <link wiki="Tag:tourism=hotel" />
            <space />
            <key key="tourism" value="hotel" />
            <reference ref="name_operator" />
            <combo key="stars" text="Stars" values="1,2,3,4,5,6,7" />
            <preset_link text="Add this..." preset_name="Contact (Common Schema)" />
            <preset_link text="...and this..." preset_name="Address" />
            <preset_link text="...and this..." preset_name="Payment Methods" />
            <text key="rooms" text="Rooms" />
            <text key="beds" text="Beds" />
            <reference ref="wheelchair" />
            <space />
            <reference ref="internet_smoking" />
            <space />
            <preset_link preset_name="Residential Building" />
        </item>

… yields …


comment:4 Changed 8 weeks ago by stoecker

Resolution: fixed
Status: closedreopened

If you add new features you also need to update the documentation for these: wiki:TaggingPresets.

comment:5 Changed 8 weeks ago by simon04

Resolution: fixed
Status: reopenedclosed

comment:6 in reply to:  5 Changed 8 weeks ago by skyper

comment:7 Changed 8 weeks ago by simon04

[o35422] - I18n: PresetLink: allow to customize label text

comment:8 Changed 4 weeks ago by Klumbumbus

Milestone: 20.0420.05

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.