Modify

Opened 4 years ago

Last modified 13 months ago

#19008 new defect

Differences in results outside downloaded area between no download area at all and small download area somewhere

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report download area Cc:

Description

This is a follow up of #18414 and the real problem. See my 18414#comment:11 and followups.
See ticket:18414:josm_way_end_node_near_other.joz for example data. Please use the "unlocked" layers.

What steps will reproduce the problem?

  1. Have the same data in two layers. One without any download area, the other with a minimal download area containing no data somewhere.
  2. Run validator

What is the expected result?

Same results in my case as all data is outside downloaded area

What happens instead?

Different results

Please provide any additional information below. Attach a screenshot if possible.

At least Way end node near other highway and Way end node near other way show different results but I believe there are more test affected.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-27 15:39:19 +0100 (Fri, 27 Mar 2020)
Revision:16205
Build-Date:2020-03-28 02:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (4)

josm_19008_linked_highway.osm (1.2 KB ) - added by skyper 4 years ago.
example for highway=*_link
14891.osm.bz2 (3.4 KB ) - added by GerdP 4 years ago.
unit test data
14891_Darea.osm.bz2 (3.6 KB ) - added by skyper 4 years ago.
Test file with download area
19008.link-roads.patch (4.1 KB ) - added by GerdP 4 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by GerdP, 4 years ago

Same results in my case as all data is outside downloaded area

The logic in JOSM is different. If there is no download area nothing is outside of the download area.

comment:2 by skyper, 4 years ago

Summary: Differences results outside downloaded area between no download area at all and small download area somewhereDifferences in results outside downloaded area between no download area at all and small download area somewhere

by skyper, 4 years ago

example for highway=*_link

comment:3 by skyper, 4 years ago

josm_19008_linked_highway.osm is an example for Highway link is not linked to adequate highway/link

by GerdP, 4 years ago

Attachment: 14891.osm.bz2 added

unit test data

comment:4 by GerdP, 4 years ago

The current code checks if any of the end nodes of the way is outside of a download area. If so, the test is skipped for that way.
It would be easy to change the test so that it also skips when the file doesn't contain any download area, but this would break the unit tests, try attached file.
I guess you want to be warned when you know that your data contains all the "important" ways.

in reply to:  4 comment:5 by skyper, 4 years ago

Replying to GerdP:

I guess you want to be warned when you know that your data contains all the "important" ways.

I want to minimize the false positives. E.g. all test relying on more than one object need to make sure that all important objects are downloaded. For "crossing without connection" it is not important if some data is missing but for test which rely on parents, connection or nearby unconnected objects it is important.

No download area should mean everything outside downloaded area.

by skyper, 4 years ago

Attachment: 14891_Darea.osm.bz2 added

Test file with download area

in reply to:  4 comment:6 by skyper, 4 years ago

Replying to GerdP:

try attached file.

Does this modified version help ?
14891_Darea.osm.bz2​

by GerdP, 4 years ago

Attachment: 19008.link-roads.patch added

comment:7 by GerdP, 4 years ago

No, because the question was if the test should always produce the warning.
The attached patch suppresses the false positive from your example and still produces the warning for roundabout case.
This test is a bit problematic for this subject as it already produces dubious results when all data in a download area. See #16803.

comment:8 by skyper, 13 months ago

See #22847.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to skyper.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.