Modify

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#19003 closed defect (fixed)

different results with layer state "locked"

Reported by: skyper Owned by: team
Priority: normal Milestone: 20.03
Component: Core validator Version:
Keywords: template_report locked layer Cc:

Description

See GerdP's comment on #17914 and followups.

What steps will reproduce the problem?

  1. Have the same data layer once with state "normal" once with state "locked", see example session
  2. run validator on both layers
  3. compare the results

What is the expected result?

Same results

What happens instead?

Different results

Please provide any additional information below. Attach a screenshot if possible.

Some test seem to be skipped with state "locked"

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-27 15:39:19 +0100 (Fri, 27 Mar 2020)
Revision:16205
Build-Date:2020-03-28 02:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (4)

comment:1 Changed 2 months ago by skyper

Replying to GerdP:

I'll have a closer look tomorrow. A potential problem with locked layers is the autofix function. Makes no sense to create fixes for locked layers, right? Or should we produce them to get the same result?

Thanks.

I tend to just disable the fix button and show the same results.

comment:2 Changed 2 months ago by GerdP

Resolution: fixed
Status: newclosed

In 16220/josm:

fix #19003: different validator results with layer state "locked"

  • replace getEditDataSet() by getActiveDataSet()

comment:3 Changed 2 months ago by GerdP

The "Fix" button is already disabled when the dataset for the corresponding osm object is locked. So, possible fixes are computed but cannot be executed.

comment:4 Changed 2 months ago by skyper

Keywords: locked layer added
Milestone: 20.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.