Modify

Opened 4 years ago

Last modified 8 months ago

#18974 new enhancement

[patch] Add support for shortcut 'zoom to selection' (key '3') when note is selected

Reported by: jbcorbeille-temp3@… Owned by: team
Priority: normal Milestone:
Component: Core notes Version:
Keywords: template_report zoom shortcut Cc:

Description

What steps will reproduce the problem?

  1. Open Notes panel, download some notes, select one note.
  2. press key '3', default shortcut for 'zoom to selection'.
  3. Nothing happens. May/should zoom to the selected note, as when a single node is selected

What is the expected result?

May/should zoom to the selected note, as when a single node is selected.

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-26 10:50:27 +0100 (Wed, 26 Feb 2020)
Build-Date:2020-02-26 09:52:41
Revision:15937
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15937 fr) Windows 7 64-Bit
OS Build number: Windows 7 Home Premium (7601)
Memory Usage: 764 MB / 878 MB (189 MB allocated, but free)
Java version: 1.8.0_151-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1366x768
Maximum Screen Size: 1366x768
Dataset consistency test: No problems found

Plugins:
+ DirectUpload (35248)
+ apache-commons (35362)
+ apache-http (35092)
+ continuosDownload (91)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35092)
+ jna (35092)
+ jts (35122)
+ opendata (35330)
+ poly (35248)
+ reltoolbox (35313)
+ reverter (35313)
+ scripting (30796)
+ todo (30306)
+ turnrestrictions (35313)
+ utilsplugin2 (35366)

Map paint styles:
+ <josm.pref>\elemstyles_JB.mapcss

Last errors/warnings:
- W: org.openstreetmap.josm.io.OsmTransferException: Impossible de joindre le serveur. Veuillez vérifier votre connexion Internet.. Cause : java.net.SocketTimeoutException: connect timed out
- W: java.net.UnknownHostException: api.openstreetmap.org
- W: Already here java.net.SocketTimeoutException: connect timed out
- E: java.net.UnknownHostException: api.openstreetmap.org
- W: org.openstreetmap.josm.io.OsmTransferException: Impossible de joindre le serveur. Veuillez vérifier votre connexion Internet.. Cause : java.net.UnknownHostException: api.openstreetmap.org
- W: java.net.UnknownHostException: api.openstreetmap.org
- W: Already here java.net.UnknownHostException: api.openstreetmap.org
- E: java.net.UnknownHostException: api.openstreetmap.org
- W: org.openstreetmap.josm.io.OsmTransferException: Impossible de joindre le serveur. Veuillez vérifier votre connexion Internet.. Cause : java.net.UnknownHostException: api.openstreetmap.org
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out

Attachments (2)

center-map-on-note.patch (2.0 KB ) - added by NoteRoamer 8 months ago.
Patch to add a "Center map on note" to the note list menu.
center-map-on-note-v2.patch (2.2 KB ) - added by NoteRoamer 8 months ago.
Add center man on note option to note list menu

Download all attachments as: .zip

Change History (6)

comment:1 by skyper, 4 years ago

Component: CoreCore notes
Keywords: zoom shortcut added
Priority: minornormal
Type: defectenhancement

by NoteRoamer, 8 months ago

Attachment: center-map-on-note.patch added

Patch to add a "Center map on note" to the note list menu.

comment:2 by NoteRoamer, 8 months ago

Summary: Add support for shortcut 'zoom to selection' (key '3') when note is selected[patch] Add support for shortcut 'zoom to selection' (key '3') when note is selected

It is possible to center the mapview on a note by double clicking on the note in the notes list. (I added this information to the Wiki yesterday).

The key 3 shortcut seems reserved to the Selections list as it is not used by for example the relations or validation dialogs. Also it is possible to both have a selection on a node/way in the selections list and a selection of a note in the note list which causes a conflict on what the key should zoom to.

I have attached a patch that adds a "Center map on note" to the right click menu which should make this feature a bit more visible and at the same time bring it a little close i look and feel to some of the other dialogs.

Is the patch good enough for inclusion and is there more to do before closing this ticket?

comment:3 by stoecker, 8 months ago

Why do you use a custom constructor. Use a similar one to CloseAction() and register a shortcut with "KeyEvent.VK_UNDEFINED, Shortcut.NONE", then you have what you want ;-)

by NoteRoamer, 8 months ago

Attachment: center-map-on-note-v2.patch added

Add center man on note option to note list menu

comment:4 by NoteRoamer, 8 months ago

Because I am a noob. :) Thank you for looking at it, a new version is attached.

I am a bit uncertain about the icon. The function used does not zoom which I think is a feature, so "Jump to" icon seems right.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to jbcorbeille-temp3@….
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.