Modify

Opened 3 months ago

Closed 3 months ago

Last modified 7 weeks ago

#18918 closed enhancement (fixed)

pressing CTRL+H in changeset manager does not trigger history

Reported by: schoschi Owned by: Don-vip
Priority: minor Milestone: 20.03
Component: Core Version:
Keywords: template_report changeset manager shortcut history Cc:

Description

What steps will reproduce the problem?

  1. Menu > Windows > Changeset manager (DE: Änderungssatzverwaltung)
  2. My Changesets, select one, download changeset content
  3. Switch to tab content

4a. Select one or multiple rows and press CTRL+H (DE: STRG+H) to call history (DE: Chronik)
4b. Select one or multiple rows and click book icon to call history

What is the expected result?

both steps 4a and 4b do open history. According to #17270 it worked or still works but not in my installation.

What happens instead?

only step 4b opens history but not pressing CTRL+H - which works in JOSM main window.

Also tried with Java version: 11.0.5+10, AdoptOpenJDK, OpenJDK 64-Bit Server VM

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-26 10:50:27 +0100 (Wed, 26 Feb 2020)
Build-Date:2020-02-26 09:52:41
Revision:15937
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15937 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 968 MB / 3625 MB (777 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 3240x2160, \Display1 2560x1440
Maximum Screen Size: 3240x2160

Plugins:
+ DirectUpload (35248)
+ InfoMode (35248)
+ Mapillary (1.5.20)
+ OpeningHoursEditor (35250)
+ PicLayer (35313)
+ ShapeTools (1240)
+ apache-commons (35092)
+ apache-http (35092)
+ buildings_tools (35248)
+ contourmerge (v0.1.6)
+ jna (35092)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/SkiingTrail&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Mountains&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Heritage&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OpenPisteMap&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: Cannot lock cache directory. Will not use disk cache
- W: Cannot start IPv4 remotecontrol server on port 8111: Address already in use: JVM_Bind
- W: Cannot start IPv6 remotecontrol server on port 8111: Address already in use: JVM_Bind

Attachments (0)

Change History (8)

comment:1 Changed 3 months ago by skyper

Component: Plugin changeset_viewerCore
Keywords: changeset manager shortcut added
Type: defectenhancement

comment:2 Changed 3 months ago by GerdP

I don't see how #17270 is related to this. I never tried what you describe here.

comment:3 in reply to:  2 Changed 3 months ago by schoschi

Replying to GerdP:

I don't see how #17270 is related to this. I never tried what you describe here.

I understood you're acutally using CTRL+H (so it is working in your installation) and would like to improve the bevhavior when multiple objects are selected. Anyway, even when misunderstood, it's not that relevant for this ticket :-)

Last edited 3 months ago by schoschi (previous) (diff)

comment:4 Changed 3 months ago by GerdP

CRTH+H works, but not in the Changeset Manager. #17270 is about the use in the data layer.

comment:5 Changed 3 months ago by Don-vip

Keywords: history added

comment:6 Changed 3 months ago by Don-vip

Milestone: 20.03
Owner: changed from team to Don-vip
Status: newassigned

comment:7 Changed 3 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 16123/josm:

fix #18918 - Enable Ctrl-H shortcut to display history of primitives selected in changeset manager

comment:8 Changed 7 weeks ago by schoschi

4a + 4b work fine in v16239 - thank you :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.