Modify

Opened 16 months ago

Closed 2 weeks ago

Last modified 8 days ago

#17270 closed enhancement (fixed)

Improve History (Ctrl+H) when multiple objects are selected

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.05
Component: Core Version:
Keywords: template_report history Cc: stoecker

Description

What steps will reproduce the problem?

  1. Select multiple objects, e.g. 10 nodes
  2. Press Ctrl+H

(I know this not a good idea, but sometimes it happens by mistake)

What is the expected result?

A progress bar showing how many objects are processed followed by one popup showing a list of elements.
A double click on one of the elements should show the "History dialog" for that element. A single click should hilight the element.

What happens instead?

  • The progress bar shows progress for the first 5 nodes, for the last 5 the progress bar stays near 100%.

(each node creates two sub tasks, so the initial count might be doubled to solve that)

  • 10 popup dialogs are presented filling large parts of the screen, one has to close each one by clicking on it and pressing ESC unless you were fast enough to press Cancel.

Please provide any additional information below. Attach a screenshot if possible.

Possible improvement 1: If you repeat that action for only one of the previously selected nodes the data is downloaded again from the server. In the "Changeset Manager" the data is only loaded once.
Possible improvement 2: If more than x elements are selected it might useful to show a popup like "This will download the full history for x elements. Do you want to continue?"

Build-Date:2019-01-28 17:47:08
Revision:14748
Is-Local-Build:true

Identification: JOSM/1.5 (14748 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 726 MB / 1753 MB (128 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:53420, -ea, -Dfile.encoding=UTF-8]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34867)
+ continuosDownload (82)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34820)
+ opendata (34867)
+ pbf (34576)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34867)
+ undelete (34867)
+ utilsplugin2 (34867)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Failed to locate resource '/README'.
- W: Failed to locate resource '/CONTRIBUTION'.
- W: Failed to locate resource '/LICENSE'.

Attachments (3)

17270.patch (694 bytes) - added by GerdP 16 months ago.
simple patch to improve progress bar
17270-focus.patch (1.3 KB) - added by GerdP 4 weeks ago.
when closing one of many history dialogs, set focus to the last
17270-focus-and-count.patch (3.2 KB) - added by GerdP 4 weeks ago.

Download all attachments as: .zip

Change History (12)

Changed 16 months ago by GerdP

Attachment: 17270.patch added

simple patch to improve progress bar

comment:1 Changed 16 months ago by GerdP

In 14756/josm:

see #17270: improve progress bar by doubling the tick count to match the executed tasks

Changed 4 weeks ago by GerdP

Attachment: 17270-focus.patch added

when closing one of many history dialogs, set focus to the last

comment:2 Changed 4 weeks ago by GerdP

Not sure if this is the normal GUI behaviour. Assume user clicks on 3rd of 5 dialogs and closes it. It would also make sense to focus on the next or previous relative to the closed one.
At least this patch allows to close all dialogs by pressing ESC multiple times without using the mouse.

comment:3 Changed 4 weeks ago by GerdP

Milestone: 20.05

comment:4 Changed 4 weeks ago by skyper

Talking about focus the window manager will always be involved if multiple dialog windows are in play.

For the relation editor we already have a warning if more than five are opened simultaneously. Maybe this could be adopted for other dialogs.

Changed 4 weeks ago by GerdP

Attachment: 17270-focus-and-count.patch added

comment:5 Changed 4 weeks ago by GerdP

Cc: stoecker added

@skyper: Good hint :)
The new patch adds the dialog and a new user preference warn.open.maxhistory.

@Dirk: I've reused the code from r6728. The comment

/* I18N english text for value 1 makes no real sense, never called for values <= maxrel (usually 5) */

is also true for this patch. If user sets warn.open.maxhistory to 0 the text is quite strange:
"You are about to open 1 different history dialog simultaneously."
I would change the text to
"You are about to open 1 history dialog."
Same for relation editor.

comment:6 Changed 3 weeks ago by Klumbumbus

Milestone: 20.0520.05old

Milestone renamed

comment:7 Changed 3 weeks ago by Klumbumbus

Milestone: 20.05old20.05

comment:8 Changed 2 weeks ago by GerdP

Resolution: fixed
Status: newclosed

In 16394/josm:

fix #17270: Improve History (Ctrl+H) when multiple objects are selected

  • when closing one of many history dialogs, set focus to the last
  • dialog and a new user preference warn.open.maxhistory (default 5) to show warning if more than five are opened simultaneously

comment:9 Changed 8 days ago by GerdP

In 16464/josm:

see #17270: apply warn.open.maxhistory only on not-new objects

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.