Opened 7 weeks ago

Last modified 7 weeks ago

#17270 new enhancement

Improve History (Ctrl+H) when multiple objects are selected

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report history Cc:


What steps will reproduce the problem?

  1. Select multiple objects, e.g. 10 nodes
  2. Press Ctrl+H

(I know this not a good idea, but sometimes it happens by mistake)

What is the expected result?

A progress bar showing how many objects are processed followed by one popup showing a list of elements.
A double click on one of the elements should show the "History dialog" for that element. A single click should hilight the element.

What happens instead?

  • The progress bar shows progress for the first 5 nodes, for the last 5 the progress bar stays near 100%.

(each node creates two sub tasks, so the initial count might be doubled to solve that)

  • 10 popup dialogs are presented filling large parts of the screen, one has to close each one by clicking on it and pressing ESC unless you were fast enough to press Cancel.

Please provide any additional information below. Attach a screenshot if possible.

Possible improvement 1: If you repeat that action for only one of the previously selected nodes the data is downloaded again from the server. In the "Changeset Manager" the data is only loaded once.
Possible improvement 2: If more than x elements are selected it might useful to show a popup like "This will download the full history for x elements. Do you want to continue?"

Build-Date:2019-01-28 17:47:08

Identification: JOSM/1.5 (14748 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 726 MB / 1753 MB (128 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:53420, -ea, -Dfile.encoding=UTF-8]
Program arguments: [--debug]
Dataset consistency test: No problems found

+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34867)
+ continuosDownload (82)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34820)
+ opendata (34867)
+ pbf (34576)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34867)
+ undelete (34867)
+ utilsplugin2 (34867)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Failed to locate resource '/README'.
- W: Failed to locate resource '/CONTRIBUTION'.
- W: Failed to locate resource '/LICENSE'.

Attachments (1)

17270.patch (694 bytes) - added by GerdP 7 weeks ago.
simple patch to improve progress bar

Download all attachments as: .zip

Change History (2)

Changed 7 weeks ago by GerdP

Attachment: 17270.patch added

simple patch to improve progress bar

comment:1 Changed 7 weeks ago by GerdP

In 14756/josm:

see #17270: improve progress bar by doubling the tick count to match the executed tasks

Modify Ticket

Change Properties
Set your email in Preferences
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to GerdP
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.