#18916 closed enhancement (fixed)
[PATCH] Add Apache Commons Math to apache-commons
| Reported by: | taylor.smock | Owned by: | Don-vip |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin apache-commons | Version: | |
| Keywords: | apache, math | Cc: |
Description
Attachments (5)
Change History (14)
by , 5 years ago
| Attachment: | 18916.patch added |
|---|
comment:1 by , 5 years ago
I'm using Apache Commons Math4 instead of Math3 since the github repo no longer has Math3 in it.
I'm running down some build issues now.
comment:2 by , 5 years ago
| Summary: | [PATCH] Add Apache Commons Math to apache-commons → [WIP PATCH] Add Apache Commons Math to apache-commons |
|---|
comment:3 by , 5 years ago
| Summary: | [WIP PATCH] Add Apache Commons Math to apache-commons → [PATCH] Add Apache Commons Math to apache-commons |
|---|
I fixed the compile issues with regards to the math4 external, but there are a lot more svn externals now (I think ~20 more).
Please note that there is a pre-existing issue where the compress package is failing to build (cannot find symbol this.encOS?)
by , 5 years ago
| Attachment: | 18916.2.patch added |
|---|
Fix compile issues (using ivy -- zstd-jni lib was too old)
comment:4 by , 5 years ago
Thanks, it's much better to use Ivy rather than 20 new svn:externals. I'll take a look this week-end.
follow-up: 6 comment:5 by , 5 years ago
I'll clarify the patch -- I'm still using 20 new svn:externals, since that is what the plugin was doing previously.
I did add an ivy dependency file so that it would be easier to update binary libraries (specifically, just zstd-jni is done right now).
If we want to just get the jar files and not do the build ourselves, that would have been a lot easier (I spent way too much time getting the externals to work).
It shouldn't be too difficult for me to modify the project to just use Ivy instead of svn:externals (I was doing that with my aborted apache-commons-math plugin, which I should probably remove from the plugin list...)
comment:6 by , 5 years ago
Replying to taylor.smock:
If we want to just get the jar files and not do the build ourselves, that would have been a lot easier (I spent way too much time getting the externals to work).
Sorry, I didn't thought you would have to add so many externals.
It shouldn't be too difficult for me to modify the project to just use Ivy instead of svn:externals (I was doing that with my aborted apache-commons-math plugin, which I should probably remove from the plugin list...)
It's the right thing to do. It will be more performant, and will restore the build with JDK14. Right now we can't build plugins on JDK14 because of https://issues.apache.org/jira/browse/COMPRESS-507 and Commons Compress project updates/fixes seem to take a lot of time.
by , 5 years ago
| Attachment: | 18916.4.patch added |
|---|
All the Ivy (hey, no warnings now, except for CheckstyleNature)
comment:7 by , 5 years ago
18916.4.patch no longer uses svn externals (its all in Ivy).
I didn't think I'd have to add that many externals either, but Math4 depended upon another package which depended upon another...
Since it is now using Ivy for dependencies, JDK14 will work now, I guess? (The latest version I have installed is 13).
I should note that I am now using Math3 (since Math4 isn't released yet).
comment:8 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in [o35362:35363]. Thanks a lot!
Add apache commons math4