Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#18916 closed enhancement (fixed)

[PATCH] Add Apache Commons Math to apache-commons

Reported by: taylor.smock Owned by: Don-vip
Priority: normal Milestone:
Component: Plugin apache-commons Version:
Keywords: apache, math Cc:

Description


Attachments (5)

18916.patch (1.2 KB) - added by taylor.smock 3 months ago.
Add apache commons math4
18916.1.patch (3.6 KB) - added by taylor.smock 3 months ago.
Fix the compile issues (mostly)
18916.2.patch (7.9 KB) - added by taylor.smock 3 months ago.
Fix compile issues (using ivy -- zstd-jni lib was too old)
18916.3.patch (9.2 KB) - added by taylor.smock 3 months ago.
Update Eclipse to use IvyDE
18916.4.patch (13.7 KB) - added by taylor.smock 3 months ago.
All the Ivy (hey, no warnings now, except for CheckstyleNature)

Download all attachments as: .zip

Change History (13)

Changed 3 months ago by taylor.smock

Attachment: 18916.patch added

Add apache commons math4

comment:1 Changed 3 months ago by taylor.smock

I'm using Apache Commons Math4 instead of Math3 since the github repo no longer has Math3 in it.

I'm running down some build issues now.

comment:2 Changed 3 months ago by taylor.smock

Summary: [PATCH] Add Apache Commons Math to apache-commons[WIP PATCH] Add Apache Commons Math to apache-commons

Changed 3 months ago by taylor.smock

Attachment: 18916.1.patch added

Fix the compile issues (mostly)

comment:3 Changed 3 months ago by taylor.smock

Summary: [WIP PATCH] Add Apache Commons Math to apache-commons[PATCH] Add Apache Commons Math to apache-commons

I fixed the compile issues with regards to the math4 external, but there are a lot more svn externals now (I think ~20 more).

Please note that there is a pre-existing issue where the compress package is failing to build (cannot find symbol this.encOS?)

Changed 3 months ago by taylor.smock

Attachment: 18916.2.patch added

Fix compile issues (using ivy -- zstd-jni lib was too old)

Changed 3 months ago by taylor.smock

Attachment: 18916.3.patch added

Update Eclipse to use IvyDE

comment:4 Changed 3 months ago by Don-vip

Thanks, it's much better to use Ivy rather than 20 new svn:externals. I'll take a look this week-end.

comment:5 Changed 3 months ago by taylor.smock

I'll clarify the patch -- I'm still using 20 new svn:externals, since that is what the plugin was doing previously.

I did add an ivy dependency file so that it would be easier to update binary libraries (specifically, just zstd-jni is done right now).

If we want to just get the jar files and not do the build ourselves, that would have been a lot easier (I spent way too much time getting the externals to work).

It shouldn't be too difficult for me to modify the project to just use Ivy instead of svn:externals (I was doing that with my aborted apache-commons-math plugin, which I should probably remove from the plugin list...)

comment:6 in reply to:  5 Changed 3 months ago by Don-vip

Replying to taylor.smock:

If we want to just get the jar files and not do the build ourselves, that would have been a lot easier (I spent way too much time getting the externals to work).

Sorry, I didn't thought you would have to add so many externals.

It shouldn't be too difficult for me to modify the project to just use Ivy instead of svn:externals (I was doing that with my aborted apache-commons-math plugin, which I should probably remove from the plugin list...)

It's the right thing to do. It will be more performant, and will restore the build with JDK14. Right now we can't build plugins on JDK14 because of https://issues.apache.org/jira/browse/COMPRESS-507 and Commons Compress project updates/fixes seem to take a lot of time.

Changed 3 months ago by taylor.smock

Attachment: 18916.4.patch added

All the Ivy (hey, no warnings now, except for CheckstyleNature)

comment:7 Changed 3 months ago by taylor.smock

18916.4.patch no longer uses svn externals (its all in Ivy).

I didn't think I'd have to add that many externals either, but Math4 depended upon another package which depended upon another...

Since it is now using Ivy for dependencies, JDK14 will work now, I guess? (The latest version I have installed is 13).

I should note that I am now using Math3 (since Math4 isn't released yet).

comment:8 Changed 3 months ago by Don-vip

Resolution: fixed
Status: newclosed

Fixed in [o35362:35363]. Thanks a lot!

Last edited 3 months ago by Don-vip (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.