Modify

Opened 4 months ago

Last modified 5 weeks ago

#18866 new enhancement

Transform Potlatch2 mappaint style icons to SVG

Reported by: Stereo Owned by: Stereo
Priority: normal Milestone:
Component: Core Version:
Keywords: svg icon potlatch2 Cc:

Description

Since we have an icon scaling on hidpi screens now (ticket:9995#comment:110) it would be nice to transform all icons to svg. Preset icons are already all svg (#13357) and GUI icons are making great progress (#15240).

https://www.sjjb.co.uk/mapicons/contactsheet has a lot of icons that we use in the potlatch2 theme - https://www.sjjb.co.uk/mapicons/svg/accommodation/alpinehut.svg could replace source:trunk/resources/images/icons/accommodation_alpinehut.n.16.png resources/images/icons/accommodation_alpinehut.n.16.png etc.

http://osm-icons.org/wiki/Icons has more of the same icons

Attachments (0)

Change History (11)

comment:1 Changed 4 months ago by Stereo

In https://josm.openstreetmap.de/timeline?from=2020-03-04T15%3A10%3A27%2B01%3A00&precision=second , stoecker writes:

A zip file with the new images and a small shell script doing the necessary svn commands would probable be the best idea (old icons moved with "svn mv" to nodist directory).

comment:2 Changed 4 months ago by Klumbumbus

Component: CoreInternal mappaint style

comment:3 Changed 4 months ago by Klumbumbus

Summary: Transform Potlatch2 theme icons to SVGTransform Potlatch2 mappaint style icons to SVG

Before changing the icons in JOSM maybe first ask the P2 guys if they are interested in switching to svg. Then the change can be made there first.

comment:4 Changed 4 months ago by Stereo

Yeah, I notice that the P2 style hasn't been pulled since 2016, and that the patches could, in some cases, be backported.

I'll check with Richard.

comment:5 Changed 4 months ago by Don-vip

Keywords: svg icon potlatch2 added

comment:6 Changed 3 months ago by Stereo

Richard has no plans to convert the Potlatch2 style to SVG since Flash doesn't support it. I didn't get the feeling that he was planning any changes on it, especially considering Flash's imminent demise.

Are there any reasons other than historical for which the Potlatch2 style is built-in and not a custom style like the rest of the other styles?

comment:7 in reply to:  6 Changed 3 months ago by Klumbumbus

Replying to Stereo:

Are there any reasons other than historical for which the Potlatch2 style is built-in and not a custom style like the rest of the other styles?

Probably because it needs to be patched to work in JOSM.

comment:8 Changed 3 months ago by Don-vip

Also, the P2 style is a general style, not a feature-specific one.

comment:9 Changed 3 months ago by Stereo

Component: Internal mappaint styleCore

Since Richard doesn't intend to work on it anymore, (one day) I will take the patched version, integrate any changes done upstream since, change the icons to vectors and host it on the wiki here, like https://josm.openstreetmap.de/wiki/Styles/iD

comment:10 Changed 5 weeks ago by anonymous

Status: assignednew

comment:11 Changed 5 weeks ago by stoecker

I'd say the main reason is historical. There is no need to have it internal.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Stereo.
as The resolution will be set.
to The owner will be changed from Stereo to the specified user.
The owner will change to Stereo
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from Stereo to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.