False opening_hours warning with SH and PH

[skyper]

What steps will reproduce the problem?

1. Have opening_hours=10:00-17:00; Jan-May,Nov-Dec Mo off; PH,SH Mo 09:00-17:00
2. Run validator

What is the expected result?

No warning

What happens instead?

I get: Encountered: <HYPHEN> "- " at line 1, column 14Was expecting: <EOF> (1)

Please provide any additional information below. Attach a screenshot if possible.

Additional, the warning is not human readable and autofix misses.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-04 00:45:22 +0100 (Wed, 04 Mar 2020)
Revision:16027
Build-Date:2020-03-04 02:30:58
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

From #18140 skyper in comment 40:

For opening_hours=Mo-Su,PH 10:00-21:30 I get Opening hours syntax - Holiday after weekday at line 1, column 10

which is to strict see ypid23's comment 10 on #18807 and not human readable

[simon04]

skyper, would you please report this error to ​https://github.com/simonpoole/OpeningHoursParser/issues – thank you!

[skyper]

Replying to skyper:

From #18140 skyper in comment 40:

For opening_hours=Mo-Su,PH 10:00-21:30 I get Opening hours syntax - Holiday after weekday at line 1, column 10

which is to strict see ypid23's comment 10 on #18807 and not human readable

I would say, this is another case, where we need a strict variant and a relaxed one and where the relaxed variant is used in JOSM.

[skyper]

Replying to simon04:

skyper, would you please report this error to ​https://github.com/simonpoole/OpeningHoursParser/issues – thank you!

See ​https://github.com/simonpoole/OpeningHoursParser/issues/41 for the main issue.

[simon04]

Thank you!