Modify

Opened 3 months ago

Closed 3 months ago

#18857 closed defect (invalid)

False opening_hours warning with SH and PH

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report opening_hours Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have opening_hours=10:00-17:00; Jan-Mai,Nov-Dec Mo off; PH,SH Mo 09:00-17:00
  2. Run validator

What is the expected result?

No warning

What happens instead?

I get: Encountered: <HYPHEN> "- " at line 1, column 14Was expecting: <EOF> (1)

Please provide any additional information below. Attach a screenshot if possible.

Additional, the warning is not human readable and autofix misses.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-04 00:45:22 +0100 (Wed, 04 Mar 2020)
Revision:16027
Build-Date:2020-03-04 02:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (10)

comment:1 Changed 3 months ago by skyper

Description: modified (diff)

comment:2 Changed 3 months ago by skyper

From #18140 skyper in comment 40:

For opening_hours=Mo-Su,PH 10:00-21:30 I get Opening hours syntax - Holiday after weekday at line 1, column 10

which is to strict see ypid23's comment 10 on #18807 and not human readable

comment:3 Changed 3 months ago by simon04

skyper, would you please report this error to https://github.com/simonpoole/OpeningHoursParser/issues – thank you!

comment:4 Changed 3 months ago by skyper

Replying to skyper:

From #18140 skyper in comment 40:

For opening_hours=Mo-Su,PH 10:00-21:30 I get Opening hours syntax - Holiday after weekday at line 1, column 10

which is to strict see ypid23's comment 10 on #18807 and not human readable

I would say, this is another case, where we need a strict variant and a relaxed one and where the relaxed variant is used in JOSM.

Last edited 3 months ago by skyper (previous) (diff)

comment:5 in reply to:  3 Changed 3 months ago by skyper

Replying to simon04:

skyper, would you please report this error to https://github.com/simonpoole/OpeningHoursParser/issues – thank you!

See https://github.com/simonpoole/OpeningHoursParser/issues/41 for the main issue.

comment:6 Changed 3 months ago by simon04

Thank you!

comment:7 Changed 3 months ago by skyper

Description: modified (diff)

comment:8 Changed 3 months ago by skyper

Description: modified (diff)

comment:9 Changed 3 months ago by skyper

Now, I am puzzled. The warning comes from "Mai" German for "May". So no issue but a no human readable message and the former autofix is missing.

How to handle these missing human readable warnings and the autofixes.

comment:10 Changed 3 months ago by skyper

Resolution: invalid
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.