Opened 5 years ago
Closed 5 years ago
#18857 closed defect (invalid)
False opening_hours warning with SH and PH
Reported by: | skyper | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | template_report opening_hours | Cc: |
Description (last modified by )
What steps will reproduce the problem?
- Have
opening_hours=10:00-17:00; Jan-Mai,Nov-Dec Mo off; PH,SH Mo 09:00-17:00
- Run validator
What is the expected result?
No warning
What happens instead?
I get: Encountered: <HYPHEN> "- " at line 1, column 14Was expecting: <EOF> (1)
Please provide any additional information below. Attach a screenshot if possible.
Additional, the warning is not human readable and autofix misses.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2020-03-04 00:45:22 +0100 (Wed, 04 Mar 2020) Revision:16027 Build-Date:2020-03-04 02:30:58 URL:https://josm.openstreetmap.de/svn/trunk
Attachments (0)
Change History (10)
comment:1 by , 5 years ago
Description: | modified (diff) |
---|
comment:2 by , 5 years ago
follow-up: 5 comment:3 by , 5 years ago
skyper, would you please report this error to https://github.com/simonpoole/OpeningHoursParser/issues – thank you!
comment:4 by , 5 years ago
Replying to skyper:
From #18140 skyper in comment 40:
For
opening_hours=Mo-Su,PH 10:00-21:30
I getOpening hours syntax - Holiday after weekday at line 1, column 10
which is to strict see ypid23's comment 10 on #18807 and not human readable
I would say, this is another case, where we need a strict variant and a relaxed one and where the relaxed variant is used in JOSM.
comment:5 by , 5 years ago
Replying to simon04:
skyper, would you please report this error to https://github.com/simonpoole/OpeningHoursParser/issues – thank you!
See https://github.com/simonpoole/OpeningHoursParser/issues/41 for the main issue.
comment:7 by , 5 years ago
Description: | modified (diff) |
---|
comment:8 by , 5 years ago
Description: | modified (diff) |
---|
comment:9 by , 5 years ago
Now, I am puzzled. The warning comes from "Mai" German for "May". So no issue but a no human readable message and the former autofix is missing.
How to handle these missing human readable warnings and the autofixes.
comment:10 by , 5 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
From #18140 skyper in comment 40: