Modify

Opened 4 years ago

Closed 6 months ago

#18825 closed defect (fixed)

Default shortcut conflict

Reported by: gaben Owned by: team
Priority: minor Milestone:
Component: Plugin continuosDownload Version:
Keywords: template_report shortcut conflict Cc:

Description

What steps will reproduce the problem?

  1. Install continousDownload plugin on a recent JOSM version

What is the expected result?

The continousDownload plugin's default Alt+Shift+D shortcut working.

What happens instead?

The default Alt+Shift+D shortcut will remapped to Ctrl+Alt+F1, because it conflicts with download_along tool default shortcut.

2020-03-01 10:48:28.031 INFO: Reassigning shortcut 'continuosdownload:activate' from null to 640 because of conflict with Alt+Shift+D
2020-03-01 10:48:28.032 INFO: Silent shortcut conflict: 'continuosdownload:activate' moved by 'file:download_along' to 'Ctrl+Alt+F1'.

Please provide any additional information below. Attach a screenshot if possible.

If I remember correctly, a few months ago the download_along tool default shortcut changed to Alt+Shift+D.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-01 01:02:24 +0100 (Sun, 01 Mar 2020)
Build-Date:2020-03-01 02:30:56
Revision:15969
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15969 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Pro for Workstations 1909 (18363)
Memory Usage: 1091 MB / 7273 MB (708 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1200
Maximum Screen Size: 1920x1200

Plugins:
+ OpeningHoursEditor (35250)
+ apache-commons (35092)
+ continuosDownload (91)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ opendata (35330)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ utilsplugin2 (35334)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Attachments (0)

Change History (9)

comment:1 by gaben, 3 years ago

Keywords: shortcut conflict added

comment:2 by gaben, 3 years ago

Component: Plugin continuosDownloadCore shortcuts
Keywords: shortcut removed

comment:3 by skyper, 3 years ago

Component: Core shortcutsPlugin continuosDownload
Keywords: shortcut added
Version: latest

To fix this, the plugin needs to use a shortcut not occupied by core.

comment:4 by gaben, 3 years ago

That's right, but the plugin used the combination first ;)

comment:5 by taylor.smock, 19 months ago

Does anyone have a good key combo for the action?

Also, for the record, download_along was originally a plugin, and it used alt+shift+d since r22293/osm (2010-07-13).

continuousDownload has used the same shortcut since 2012-03-20 (initial git commit).

comment:6 by gaben, 19 months ago

No, unfortunately. Changed the core shortcut and stuck to the good old Alt+Shift+D combination.

Thanks for the investigation.

Last edited 19 months ago by gaben (previous) (diff)

comment:7 by taylor.smock, 6 months ago

I think removing the default shortcut will work; I don't think most people are toggling continuousDownload on and off enough for it to matter.

comment:8 by gaben, 6 months ago

That's also an option. I may be an exception because I use the shortcut on every edit session. At least it's easy to change.

comment:9 by taylor.smock, 6 months ago

Resolution: fixed
Status: newclosed

Fixed in v102.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.