Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#18760 closed defect (duplicate)

Error JOSM Validator on evaluation [opening_hours.js]: no "SH" definition.

Reported by: AnkEric Owned by: AnkEric
Priority: minor Milestone:
Component: Core validator Version:
Keywords: opening_hours Cc:

Description (last modified by AnkEric)

JOSM Validater, during validation:

An error occurred during evaluation of the value "Mo-Fr 09:23-10:14; PH off; SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition.

BTW: "SH" means: <school_holiday>. I didn't know...

/AnkEric

Attachments (2)

JOSM_Validator_Error_1.png (8.2 KB ) - added by AnkEric 4 years ago.
JOSM_Validator_Error_2.png (5.7 KB ) - added by AnkEric 4 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 by AnkEric, 4 years ago

Owner: changed from team to AnkEric

comment:2 by AnkEric, 4 years ago

Description: modified (diff)

comment:3 by GerdP, 4 years ago

Owner: changed from AnkEric to anonymous
Status: newneedinfo

I cannot reproduce this problem. We probably need the position of the object with this tag.

comment:4 by GerdP, 4 years ago

Owner: changed from anonymous to AnkEric

comment:5 by Klumbumbus, 4 years ago

Reporter: changed from anonymous to AnkEric

by AnkEric, 4 years ago

Attachment: JOSM_Validator_Error_1.png added

by AnkEric, 4 years ago

Attachment: JOSM_Validator_Error_2.png added

comment:6 by AnkEric, 4 years ago

Please: let's forgot about this one, Close it ; -))

I did find it after a long search.
Relation: #8214727 (route=bus).

I could not see the Error in JOSM Validator List of Warnings because of the Error Message: it was not added to List of Warnings.

But (1): I cannot reproduce.
I first tried to simply Set [opening_hours=Mo-Fr 09:23-10:14; PH off; SH off] on a node, but no Error!

But (2): JOSM was - just - updated to v15915. And I do believe I do see an Error "blinking", split second. Not sure though.

Also: These Errors (see: 2 Attached Images) appear to be unhandled Errors. Just blinking very shortly.
In trying to reproduce I have Exported ALL opening_hours (in the area) from Overpass into JOSM.
Running Validator: "TypeError: Cannot read property "0" from undefined". Again: no idea where or what...
Sometimes I do think Validator stops executing if this Error occurs. Again: Not sure though.

So perhaps it might be an idea to check Error handling on these blinking Messages. Or... ignore... -))

/ AnkEric

comment:7 by GerdP, 4 years ago

Resolution: irreproducible
Status: needinfoclosed

comment:8 by Klumbumbus, 4 years ago

(Possibly fixed by #18577 which was part of yesterdays new stable release.)

comment:9 by simon04, 4 years ago

Keywords: opening_hours added
Resolution: irreproducible
Status: closedreopened

comment:10 by simon04, 4 years ago

Resolution: duplicate
Status: reopenedclosed

Closed as duplicate of #17936.

comment:11 by Don-vip, 4 years ago

@AnkEric: please use the "Help -> Report bug" feature next time. Having to guess what JOSM version you're using make us lose unnecessary time.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain AnkEric.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.