#18760 closed defect (duplicate)
Error JOSM Validator on evaluation [opening_hours.js]: no "SH" definition.
| Reported by: | AnkEric | Owned by: | AnkEric |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | opening_hours | Cc: |
Description (last modified by )
JOSM Validater, during validation:
An error occurred during evaluation of the value "Mo-Fr 09:23-10:14; PH off; SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition.
BTW: "SH" means: <school_holiday>. I didn't know...
/AnkEric
Attachments (2)
Change History (13)
comment:1 by , 6 years ago
| Owner: | changed from to |
|---|
comment:2 by , 6 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 6 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
comment:4 by , 6 years ago
| Owner: | changed from to |
|---|
comment:5 by , 6 years ago
| Reporter: | changed from to |
|---|
by , 6 years ago
| Attachment: | JOSM_Validator_Error_1.png added |
|---|
by , 6 years ago
| Attachment: | JOSM_Validator_Error_2.png added |
|---|
comment:6 by , 6 years ago
Please: let's forgot about this one, Close it ; -))
I did find it after a long search.
Relation: #8214727 (route=bus).
I could not see the Error in JOSM Validator List of Warnings because of the Error Message: it was not added to List of Warnings.
But (1): I cannot reproduce.
I first tried to simply Set [opening_hours=Mo-Fr 09:23-10:14; PH off; SH off] on a node, but no Error!
But (2): JOSM was - just - updated to v15915. And I do believe I do see an Error "blinking", split second. Not sure though.
Also: These Errors (see: 2 Attached Images) appear to be unhandled Errors. Just blinking very shortly.
In trying to reproduce I have Exported ALL opening_hours (in the area) from Overpass into JOSM.
Running Validator: "TypeError: Cannot read property "0" from undefined". Again: no idea where or what...
Sometimes I do think Validator stops executing if this Error occurs. Again: Not sure though.
So perhaps it might be an idea to check Error handling on these blinking Messages. Or... ignore... -))
/ AnkEric
comment:7 by , 6 years ago
| Resolution: | → irreproducible |
|---|---|
| Status: | needinfo → closed |
comment:8 by , 6 years ago
(Possibly fixed by #18577 which was part of yesterdays new stable release.)
comment:9 by , 6 years ago
| Keywords: | opening_hours added |
|---|---|
| Resolution: | irreproducible |
| Status: | closed → reopened |
comment:10 by , 6 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | reopened → closed |
Closed as duplicate of #17936.
comment:11 by , 6 years ago
@AnkEric: please use the "Help -> Report bug" feature next time. Having to guess what JOSM version you're using make us lose unnecessary time.



I cannot reproduce this problem. We probably need the position of the object with this tag.