Remove i18n from debug logging strings?

[simon04]

Logging.debug(tr("Adding certificate for TLS connections: {0}", cert.getSubjectX500Principal().getName()));
Logging.debug(tr("Test ''{0}'' completed in {1}",
Logging.debug(tr("{0} intermediate nodes to download.", nbNodes));
Logging.debug(tr("between {0} {1} and {2} {3}", p2.lat(), p2.lon(), p1.lat(), p1.lon()));
Logging.debug(tr("Adding {0} to tag checker", i));
Logging.debug(tr("Undefined element ''{0}'' found in input stream. Skipping.", element));
Logging.debug(tr("{0} completed in {1}", title, ((MeasurableTask) task).duration));
Logging.debug(tr("Line was ignored: {0}", line));
Logging.debug(tr("Test ''{0}'' completed in {1}", getName(), stopwatch));

[stoecker]

Debugging strings meant for the eyes of developers only should be English.

[GerdP]

+1

[simon04]

In 16068/josm:

fix #18752 - Remove i18n from debug logging strings

[simon04]

In 16069/josm:

see #18752 - Harmonize stopwatch logging

[GerdP]

Seems you missed some strings. The prefix "Test" is only added for some validator tests, and the debug message is still translated:

2020-03-08 09:39:13.113 FEIN: Test Fahrspurmerkmale ausführen
2020-03-08 09:39:13.114 FEIN: 'Fahrspurmerkmale' in 1 ms beendet
2020-03-08 09:39:13.115 FEIN: Test Lange Linienabschnitte ausführen
2020-03-08 09:39:13.115 FEIN: Test Merkmalssprüfer (basierend auf MapCSS) ausführen
2020-03-08 09:39:13.149 FEIN: 'Merkmalssprüfer (basierend auf MapCSS)' in 33 ms beendet
2020-03-08 09:39:13.149 FEIN: Test Multipolygon ausführen
2020-03-08 09:39:13.155 FEIN: 'Multipolygon' in 5 ms beendet
2020-03-08 09:39:13.158 FEIN: Test Fehlender übersetzter Name (Merkmal name:*) ausführen

[simon04]

"Test" originates from the test name. I18n for stopwatch logging comes for free due to r16069 and some of its usages requiring i18n.

[GerdP]

My understanding of this ticket was that we should see the english strings for those messages.

[simon04]

My understanding was to reduce the amount of i18n work by removing a few strings.

[GerdP]

OK, I understand. Typically I use JOSM with English language anyway.

[simon04]

In 16071/josm:

see #18752 - ImageDisplay: improve logging

[simon04]

In 16084/josm:

see #18752 - FileImporter: add stopwatch logging