Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#18752 closed enhancement (fixed)

Remove i18n from debug logging strings?

Reported by: simon04 Owned by: team
Priority: minor Milestone: 20.03
Component: Core Version:
Keywords: i18n debug logging Cc:

Description

Logging.debug(tr("Adding certificate for TLS connections: {0}", cert.getSubjectX500Principal().getName()));
Logging.debug(tr("Test ''{0}'' completed in {1}",
Logging.debug(tr("{0} intermediate nodes to download.", nbNodes));
Logging.debug(tr("between {0} {1} and {2} {3}", p2.lat(), p2.lon(), p1.lat(), p1.lon()));
Logging.debug(tr("Adding {0} to tag checker", i));
Logging.debug(tr("Undefined element ''{0}'' found in input stream. Skipping.", element));
Logging.debug(tr("{0} completed in {1}", title, ((MeasurableTask) task).duration));
Logging.debug(tr("Line was ignored: {0}", line));
Logging.debug(tr("Test ''{0}'' completed in {1}", getName(), stopwatch));

Attachments (0)

Change History (13)

comment:1 Changed 3 months ago by stoecker

Debugging strings meant for the eyes of developers only should be English.

comment:2 Changed 3 months ago by Klumbumbus

Summary: Remove i18n from debug logging stings?Remove i18n from debug logging strings?

comment:3 Changed 3 months ago by GerdP

+1

comment:4 Changed 3 months ago by simon04

Resolution: fixed
Status: newclosed

In 16068/josm:

fix #18752 - Remove i18n from debug logging strings

comment:5 Changed 3 months ago by simon04

In 16069/josm:

see #18752 - Harmonize stopwatch logging

comment:6 Changed 3 months ago by GerdP

Resolution: fixed
Status: closedreopened

Seems you missed some strings. The prefix "Test" is only added for some validator tests, and the debug message is still translated:

2020-03-08 09:39:13.113 FEIN: Test Fahrspurmerkmale ausführen
2020-03-08 09:39:13.114 FEIN: 'Fahrspurmerkmale' in 1 ms beendet
2020-03-08 09:39:13.115 FEIN: Test Lange Linienabschnitte ausführen
2020-03-08 09:39:13.115 FEIN: Test Merkmalssprüfer (basierend auf MapCSS) ausführen
2020-03-08 09:39:13.149 FEIN: 'Merkmalssprüfer (basierend auf MapCSS)' in 33 ms beendet
2020-03-08 09:39:13.149 FEIN: Test Multipolygon ausführen
2020-03-08 09:39:13.155 FEIN: 'Multipolygon' in 5 ms beendet
2020-03-08 09:39:13.158 FEIN: Test Fehlender übersetzter Name (Merkmal name:*) ausführen

comment:7 Changed 3 months ago by simon04

"Test" originates from the test name. I18n for stopwatch logging comes for free due to r16069 and some of its usages requiring i18n.

comment:8 Changed 3 months ago by GerdP

My understanding of this ticket was that we should see the english strings for those messages.

comment:9 Changed 3 months ago by simon04

My understanding was to reduce the amount of i18n work by removing a few strings.

comment:10 Changed 3 months ago by GerdP

OK, I understand. Typically I use JOSM with English language anyway.

comment:11 Changed 3 months ago by GerdP

Resolution: fixed
Status: reopenedclosed

comment:12 Changed 3 months ago by simon04

In 16071/josm:

see #18752 - ImageDisplay: improve logging

comment:13 Changed 3 months ago by simon04

In 16084/josm:

see #18752 - FileImporter: add stopwatch logging

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.