[PATCH] Add a wrapper for JavaFX methods

[taylor.smock]

This wrapper creates a JFXPanel around an arbitrary JavaFX node.

It has two public methods, getPanel to get the JFXPanel to add to UI elements and getNode to get the node. It is a generic function, so the class of the node passed to the constructor is used for the return type.

ticket:14921#comment:35 indicated that the JavaFX DatePicker class would be useful for the Sentinel imagery, but I didn't want to write something that was strictly specific to the DatePicker class.

Sample usage of this class:

JavaFXWrapper<> dateWrapper = new JavaFXWrapper<>(new DatePicker());

I'm marking this as an RFC since I don't know if this should be in JOSM core, plugin JavaFX, and whether or not it would be worth pursuing.

[taylor.smock]

Initial patch

[taylor.smock]

Extend JFXPanel instead of creating a new instance

[taylor.smock]

18731.1.patch is the wrong patch. The comment does apply to 18747.1.patch.

[Don-vip]

Replying to taylor.smock:

I don't know if this should be in JOSM core, plugin JavaFX, and whether or not it would be worth pursuing.

Rather in JavaFX plugin, as we're not ready to make JOSM core depend on JavaFX features yet. But definitively worth it :)

[taylor.smock]

OK. I'll keep working on it. I was thinking of trying to take the 360 degree viewer from the Microsoft StreetSide plugin sometime, but that depends on JavaFX. :(

Current known bugs (in my working tree):

1) DatePicker objects can be tabbed to, but not out of -- tab will instead toggle the DialogsPanel. I haven't tried other components yet.
2) There are a few UI issues, but I don't know if it is due to the surrounding Swing code
3) There is an issue in the current patch where, if there wasn't a JavaFX call prior, an exception occurs. I'm thinking about modifying the constructor so that a class can be passed, but then there are possible thrown exceptions. I can probably suppress and log them, since they shouldn't happen (tm).

[taylor.smock]

Move to javafx package, rename to match javafx naming scheme, still has some issues

[taylor.smock]

Fix UI issues, fix traversal when tabbing

[taylor.smock]

Export IvyDE to for other projects

[taylor.smock]

I think this is "done".

[Don-vip]

Fixed in [o35375:35376].