Modify

Opened 2 years ago

Closed 12 months ago

Last modified 12 months ago

#18685 closed enhancement (fixed)

[patch] Add support for natural=shrub in presets

Reported by: sowa1980 Owned by: team
Priority: normal Milestone: 21.06
Component: Internal preset Version:
Keywords: natural shrub scrub Cc: stoecker

Description (last modified by sowa1980)

Добавьте пожалуйста в JOSM возможность отмечать:

  1. Линейно кустарник
  2. Точечно кустарник

Аналогично, как и с деревьями.
В данный момент , если попытаться внести эти объекты так то JOSM ругается и говорит что это ошибка.

Attachments (4)

shrub.svg (17.7 KB) - added by skyper 14 months ago.
nice icon, sadly does not work in mappaint; Own work, derived from non-commercial free to use.
josm_18685_shrub_defaultpreset.xml.patch (1.7 KB) - added by skyper 14 months ago.
preset patch
josm_18685_shrub_elemstyles.mapcss.patch (518 bytes) - added by skyper 14 months ago.
map style patch
Cartoon forest.eps (1.7 MB) - added by skyper 12 months ago.
original icon source

Download all attachments as: .zip

Change History (31)

comment:1 Changed 2 years ago by sowa1980

Description: modified (diff)

comment:2 Changed 2 years ago by simon04

Component: CoreCore mappaint
Type: defectenhancement

Translation:

Please add in JOSM the ability to mark:

  1. Linearly shrub
  2. Dotted shrub

Similarly, as with trees.
At the moment, if you try to contribute these objects, then JOSM swears and says that this is a mistake.

comment:3 Changed 2 years ago by GerdP

Is it about adding the tag natural=shrub to the presets?

comment:4 in reply to:  3 Changed 2 years ago by Klumbumbus

Replying to GerdP:

Is it about adding the tag natural=shrub to the presets?

I rather think the support of natural=scrub on unclosed ways and nodes.

comment:5 Changed 2 years ago by GerdP

I found natural=shrub only in ignoretags.cfg so I assume that there is an external file with rules which complains about this tag. JOSM doesn't render it nor does it complain when it is used on a node or unclosed way.

comment:6 Changed 2 years ago by Don-vip

Owner: changed from team to sowa1980
Status: newneedinfo

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

  • The required parts of the Status Report from your JOSM.
  • Describe what behaviour you expected.
  • Describe what did happen instead.
  • Describe if and how the issue is reproducible.
  • Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Helpsource:trunk/resources/images/bug.svg Report Bug.


comment:7 in reply to:  5 ; Changed 2 years ago by Klumbumbus

Replying to GerdP:

I assume that there is an external file with rules which complains about this tag.

No it is an internal rule "...shrub looks like scrub..." r14739 :)

shrub may be worth adding to the internal presets, especially as we "forbid" the usage of shrub scrub on nodes. Related: #15117

Last edited 2 years ago by Klumbumbus (previous) (diff)

comment:8 in reply to:  7 ; Changed 2 years ago by GerdP

Replying to Klumbumbus:

shrub may be worth adding to the internal presets, especially as we "forbid" the usage of shrub on nodes. Related: #15117

I guess you meant "usage of scrub on nodes"?

natural=shrub doesn't produce a warning for me when used on a node
natural=scrub produces a warning when used on a node
natural=shrub produces a warning when used on an unclosed way: "Unclosed way - natural type shrub"

There are several warnings for natural=scrub when not used on a closed way.

comment:9 in reply to:  8 Changed 2 years ago by Klumbumbus

Replying to GerdP:

I guess you meant "usage of scrub on nodes"?

Yes, sorry for the confusion.

comment:10 Changed 2 years ago by Don-vip

Keywords: natural shrub scrub added

comment:11 Changed 2 years ago by sowa1980

Хотелось бы иметь возможность вносить точечно и линейно данные объекты это первое, второе нет заготовок в джосме в тегах, третье это ошибки о которых я писал выше что JOSM ругается, если вносить так. кустарник не всегда занимает гектары или значительные площади особенно если это газоны, где нужна линия или точечный объект.
---
Deepl translation:
I would like to be able to make dotted and linearly these objects is the first, the second there are no blanks in the josm in the tags, the third is the errors about which I wrote above that JOSM swears if you make this. shrubs do not always occupy hectares or significant areas, especially if it's lawns where you need a line or dotted object.

Last edited 2 years ago by Don-vip (previous) (diff)

comment:12 Changed 2 years ago by Don-vip

@GerdP @Klumbumbus if this ticket is clear enough for you, can you please update its title/description?

comment:13 Changed 2 years ago by GerdP

Summary: Добавьте пожалуйста в JOSM возможность отмечать кустарник линейным и точечным объектом.Add support for natural=shrub in presets

comment:14 Changed 2 years ago by Don-vip

Owner: changed from sowa1980 to team
Status: needinfonew

comment:15 Changed 2 years ago by Don-vip

Component: Core mappaintInternal preset

comment:16 Changed 14 months ago by skyper

Owner: changed from team to skyper

Changed 14 months ago by skyper

Attachment: shrub.svg added

nice icon, sadly does not work in mappaint; Own work, derived from non-commercial free to use.

Changed 14 months ago by skyper

preset patch

Changed 14 months ago by skyper

map style patch

comment:17 Changed 14 months ago by skyper

Owner: changed from skyper to team
Summary: Add support for natural=shrub in presetsAdd support for natural=shrub in presets [patch, icon missing]

I created an nice icon, nice icon, sadly does not work in mappaint; Own work, derived from non-commercial free to use., but it does not render in mappaint.

Once again, the preset and style coding is easy, see josm_18685_shrub_defaultpreset.xml.patch and josm_18685_shrub_elemstyles.mapcss.patch, but finding nice looking icons is the challenge. Does anybody have a link or hint.

comment:18 Changed 14 months ago by skyper

Summary: Add support for natural=shrub in presets [patch, icon missing][patch] Add support for natural=shrub in presets

What I minute, I need to add the path to the icon if I want to get it rendered.

Works if the icon is placed under rescource/images/presets/landmark/.

comment:19 in reply to:  18 ; Changed 14 months ago by Klumbumbus

Replying to skyper:

What I minute, I need to add the path to the icon if I want to get it rendered.

Or you add the path where you store your icons for testing in the preferences at the lower part of the Map Paint Styles register at "Icons paths:"

comment:20 in reply to:  19 Changed 14 months ago by skyper

Replying to Klumbumbus:

Replying to skyper:

What I minute, I need to add the path to the icon if I want to get it rendered.

Or you add the path where you store your icons for testing in the preferences at the lower part of the Map Paint Styles register at "Icons paths:"

Yes, thanks, I know. Still, have to take that the paths there are correct and that no icons with identical name exist. Was just an user fault.

Talking about this ticket, in map paint style, I need a different placement and rotation for the icon, as it needs to be placed towards the to way in the case of no_entry.
Edit: Sorry, wrong ticket (#20833).
This ticket should be done with the two patches and the icon.

Last edited 14 months ago by skyper (previous) (diff)

comment:21 Changed 12 months ago by skyper

Ping

@team:
May I, please, get some feedback, thanks.
Additionally, it gets complicated if too many patches are waiting for integration as defaultpresets.xml is one file and the number of conflict will possibly get higher with more patches.

comment:22 Changed 12 months ago by Klumbumbus

The icon contains the license http://creativecommons.org/licenses/by-nc-sa/4.0/. We can't use this in JOSM as JOSM might be used for commercial purpose.

comment:23 in reply to:  22 ; Changed 12 months ago by skyper

Cc: stoecker added

Replying to Klumbumbus:

The icon contains the license http://creativecommons.org/licenses/by-nc-sa/4.0/. We can't use this in JOSM as JOSM might be used for commercial purpose.

Is it about using the software or about distributing the software?
Well, I created it myself and can add another license but I wonder if that is true. Thought it is about the reuse of the icon in another work and that BY-NC-SA 4.0 without author is working as the icon is not compiled in but I am far from being an expert on legal issues.

comment:24 in reply to:  23 ; Changed 12 months ago by Klumbumbus

Replying to skyper:

Well, I created it myself and can add another license

You wrote "derived from non-commercial free to use". When it is derived from "nc" you cannot apply a less stricter license on your derived work. What is the original source?

I am far from being an expert on legal issues.

Me too, thats why I would like to go "on the safer side" and use CC0 / PD for new icons.

Changed 12 months ago by skyper

Attachment: Cartoon forest.eps added

original icon source

comment:25 in reply to:  24 Changed 12 months ago by skyper

Replying to Klumbumbus:

Replying to skyper:

Well, I created it myself and can add another license

You wrote "derived from non-commercial free to use". When it is derived from "nc" you cannot apply a less stricter license on your derived work. What is the original source?

Damm yes, you are right.
I've attached the original source.

I am far from being an expert on legal issues.

Me too, thats why I would like to go "on the safer side" and use CC0 / PD for new icons.

There should be some stricter licenses available for icons, if not I am done with creating icons. Can we clarify this?

comment:26 Changed 12 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17930/josm:

fix #18685 - Add natural=shrub (patch by skyper, icon from https://openclipart.org/detail/258072/bush, resized, PD and CC0 licensed)

comment:27 Changed 12 months ago by Klumbumbus

Milestone: 21.06

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.