Combine ways should merge small gaps

[pangoSE]

I suggest we fix "c" combine. Small gaps are typical in MapWithAI and I suggest we notify the user (in bottom left corner) when small gaps where merged during combine.

[GerdP]

Please clarify. The default action for hotkey CTRL+C is "Edit: Copy" (at least on Windows systems). Default hotkey for "Combine ways" is just "C" and this doesn't combine unconnected ways. Do you use a plugin which behaves different or do want the standard "Combine ways" action to work different? Something like a combination of "Merge nodes" and "Combine ways"?

[pangoSE]

Replying to GerdP:

Please clarify. The default action for hotkey CTRL+C is "Edit: Copy" (at least on Windows systems). Default hotkey for "Combine ways" is just "C" and this doesn't combine unconnected ways. Do you use a plugin which behaves different or do want the standard "Combine ways" action to work different? Something like a combination of "Merge nodes" and "Combine ways"?

Sorry for the confusion. I use no plugin. I know of no such plugin, but I think this is best implemented by fixing the default behavior and perhaps limiting it to experts.

[GerdP]

Maybe this could be done in a new action but I would not want to modify the existing action as other actions use it as well.
You have at least three ways to connect two ways which have no common point but two close end points A and B

• Add one or more segments which close the gap between A and B
• Merge A with B at the postion of A
• Merge A with B at the postion of B

How should JOSM know what is right?

[stoecker]

That's not a good idea. When combine ways would change the geometry it will result in many many broken situations where people join stuff which should not be joined at all. If there are gaps people should have a look and fix them.

[taylor.smock]

@PangoSE: Small gaps do occur in the data I get from the MapWithAI service. I believe that it should be fixed on the service side (it is an issue with RapiD as well, if it is the problem I'm thinking about).

I'm inclined to let people look at each one manually instead of trying to fix it in the plugin (I do some stuff in the plugin with nodes that are nearby, but I added a very short cutoff for that).

The MapWithAI service has several problems: it has a tendency to give different data based off of the bounding box that is sent (specifically for roads that go outside of the bounding box, since what should be the same node moves a little -- I think I've seen up to 2m or 3m, but is usually <0.6m, which is what I use for the default -- you can try changing that in advanced preferences with the mapwithai.duplicatenodedistance), and I do some stuff in the plugin to try and account for that.

If you do find an area that is egregiously wrong, please report a bug in the MapWithAI plugin, and I'll take a look at the area in RapiD as well as the plugin. If both are egregiously wrong, then it is probably a server side issue. (I cannot fix those).