Modify

Opened 5 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#18572 closed enhancement (fixed)

Bicycle routes wrong warning

Reported by: Dardy Owned by: Klumbumbus
Priority: normal Milestone: 20.01
Component: Core validator Version:
Keywords: Cc:

Description

Josm validator shows a warning message when a relation route=bicycle type=route contains some points related to guideposts.

Warning message is: type 'node' of relation member with role " does not match accepted types 'way/closed way' in preset bicycle route. In route wiky (https://wiki.openstreetmap.org/wiki/Relation:route) seems that points are accepted for guidepost.

Same route with same guidepost points, but with route=hiking instead bicycle does not show any warning.
Guideposts exist for hiking but also for bike

Attachments (2)

warning.PNG (281.5 KB) - added by Dardy 5 weeks ago.
tagInfo roles.PNG (66.1 KB) - added by Dardy 4 weeks ago.

Download all attachments as: .zip

Change History (13)

Changed 5 weeks ago by Dardy

Attachment: warning.PNG added

comment:1 Changed 4 weeks ago by Klumbumbus

Owner: changed from team to Klumbumbus
Status: newassigned
Type: defectenhancement
Version: tested

comment:2 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: assignedclosed

In 15715/josm:

  • fix #18571 - deprecate unnamed=yes in favor of noname=yes
  • fix #18572, see #16458 - add guidepost role to other route relation presets too
  • fix #18573 - add isced:level to education presets

comment:3 Changed 4 weeks ago by Klumbumbus

Milestone: 20.0220.01

comment:4 Changed 4 weeks ago by Dardy

Thank you, I will try with latest josm release in order to check it.

comment:5 Changed 4 weeks ago by Dardy

Resolution: fixed
Status: closedreopened

Checked the solution with josm latest version but seems not complete. Accordingly to wiky guidepost role should not be mandatory, so there are the following cases possible:

  • relation with points and guidepost role set -> OK (fixed)
  • relation with points without guidepost role -> WARNING (to be fixed, no warning expected, as role is not mandatory)
  • relation with points with other role -> WARNING (it's correct)

comment:6 in reply to:  5 Changed 4 weeks ago by skyper

Replying to Dardy:

Checked the solution with josm latest version but seems not complete. Accordingly to wiki guidepost role should not be mandatory,

Could you, please, point me to the wiki page where you get the information about guidepost from? On the main route wiki page (route relation) the role "guidepost" is demanded.

comment:7 Changed 4 weeks ago by mdk

I see in the table "Members" at Role=guidepost a "?" (=optional) and a "0+" (Optional; 0 or more instances). Where did you see any "demanded"?

comment:8 in reply to:  7 Changed 4 weeks ago by skyper

Replying to mdk:

I see in the table "Members" at Role=guidepost a "?" (=optional) and a "0+" (Optional; 0 or more instances). Where did you see any "demanded"?

I read it differently:

  1. node with empty role is not allowed
  2. at least one way without role is needed
  3. all other members with role are optional but the role is demanded. See "stop" for example.

comment:9 in reply to:  7 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

If a guidepost is added to the relation then it must get the role "guidepost" and not stay with an empty role.

Changed 4 weeks ago by Dardy

Attachment: tagInfo roles.PNG added

comment:10 Changed 4 weeks ago by Dardy

I also read like mdk, nodes do not require mandatory role. A node in a route can be only a guidepost, so the role should be allowed even if a redundant information.
Also TagInfo (image attached) show that a blank role is a standard de facto (318k nodes with blank role vs 61k nodes with filled role) even if the wiki page is so confusing :)

comment:11 Changed 4 weeks ago by Klumbumbus

The "! 1+" and "? 0+" in the column "Recurrence" of the table osmwiki:Relation:route#Members clearly refer to the number of objects with the role written in the column "role". (See also osmwiki:Template:Rolerecurrence)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.