Opened 6 years ago
Closed 6 years ago
#18561 closed enhancement (fixed)
[PATCH] Geometry.filterInsidePolygon should take a `Collection` instead of a `List` and there should be a generic version that takes multipolygons or polygons
| Reported by: | taylor.smock | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 20.01 |
| Component: | Core | Version: | |
| Keywords: | Cc: |
Description
filterInsidePolygon doesn't use anything specific to a List for the primtives parameter, so it should use a Collection instead.
I've also found myself needing to find ways/relations enclosing an object, so I added a generic wrapper function that just checks the type of the second parameter, and calls the appropriate command.
Attachments (1)
Change History (6)
by , 6 years ago
| Attachment: | 18561.patch added |
|---|
comment:2 by , 6 years ago
| Milestone: | → 20.01 |
|---|
Thanks. I rewrote the code in org.openstreetmap.josm.gui.mappaint.mapcss.Selector.ChildOrParentSelector.ContainsFinder to use the new function.
comment:3 by , 6 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
The plugin mapwithai needs to be recompiled due to the changed function signature of filterInsidePolygon.
https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/4170/warnings3Result/new/
comment:5 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |



Initial patch