Modify

#18561 closed enhancement (fixed)

[PATCH] Geometry.filterInsidePolygon should take a `Collection` instead of a `List` and there should be a generic version that takes multipolygons or polygons

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 20.01
Component: Core Version:
Keywords: Cc:

Description

filterInsidePolygon doesn't use anything specific to a List for the primtives parameter, so it should use a Collection instead.

I've also found myself needing to find ways/relations enclosing an object, so I added a generic wrapper function that just checks the type of the second parameter, and calls the appropriate command.

Attachments (1)

18561.patch (2.4 KB) - added by taylor.smock 17 months ago.
Initial patch

Download all attachments as: .zip

Change History (6)

Changed 17 months ago by taylor.smock

Attachment: 18561.patch added

Initial patch

comment:1 Changed 17 months ago by simon04

Resolution: fixed
Status: newclosed

In 15730/josm:

fix #18561 - Add Geometry.filterInsideAnyPolygon (patch by taylor.smock, modified)

comment:2 Changed 17 months ago by simon04

Milestone: 20.01

Thanks. I rewrote the code in org.openstreetmap.josm.gui.mappaint.mapcss.Selector.ChildOrParentSelector.ContainsFinder to use the new function.

comment:3 Changed 17 months ago by simon04

Resolution: fixed
Status: closedreopened

The plugin mapwithai needs to be recompiled due to the changed function signature of filterInsidePolygon.
https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/4170/warnings3Result/new/

comment:4 Changed 17 months ago by taylor.smock

I'll fix that today.
Thank you for letting me know.

comment:5 Changed 17 months ago by taylor.smock

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.