Modify

Opened 7 weeks ago

Closed 6 weeks ago

#18505 closed enhancement (fixed)

Detect highway=crossing without crossing=*

Reported by: skyper Owned by: Don-vip
Priority: normal Milestone: 20.01
Component: Core validator Version:
Keywords: template_report crossing island Cc:

Description

What steps will reproduce the problem?

  1. have an node with highway=crossing + crossing=island
  2. run validator
  3. get a warning "deprecated tagging - crossing=island is deprecated, use crossing:island=yes instead"
  4. auto fix

What is the expected result?

A new value for crossing= + crossing:island=yes

What happens instead?

crossing= is removed and crossing:island=yes added

Please provide any additional information below. Attach a screenshot if possible.

This fix does not make it better. We need a value for crossing, in most cases `crossing=uncontrolled.
I would tend to not allow an auto fix but have the user take a look and add the correct value for crossing=.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-01-02 01:26:06 +0100 (Thu, 02 Jan 2020)
Revision:15626
Build-Date:2020-01-02 02:30:53
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (4)

comment:1 Changed 6 weeks ago by Don-vip

Milestone: 20.01
Owner: changed from team to Don-vip
Status: newassigned
Summary: Do not auto fix crossing=islandDetect highway=crossing without crossing=*
Type: defectenhancement

I would rather detect highway=crossing without crossing=* with a new info-level check

comment:2 Changed 6 weeks ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15635/josm:

fix #18505 - detect highway=crossing without crossing=* (info level)

comment:3 Changed 6 weeks ago by skyper

Resolution: fixed
Status: closedreopened

So you solve a warning to raise an info warning which is even hidden on upload and for many users, in general.

+1 for the new warning but please do not allow the auto fix. Users should have a look at the crossings especially as the last tag changes of the nodes are usually quite old and other tags like kerb=* are missing or did change, too.

Last edited 6 weeks ago by skyper (previous) (diff)

comment:4 Changed 6 weeks ago by Don-vip

Resolution: fixed
Status: reopenedclosed

We don't lose any information with the autofix, it was "just" an island before, it still is after. If people want to take a look, they can do it before using the auto fix. Other crossings without the crossing key are not less important than those tagged with crossing=island, they don't deserve particular more attention.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.