Opened 5 years ago
Closed 5 years ago
#18385 closed defect (fixed)
Combine way action may remove parts of the ways
Reported by: | GerdP | Owned by: | GerdP |
---|---|---|---|
Priority: | normal | Milestone: | 19.12 |
Component: | Core | Version: | |
Keywords: | Cc: | Don-vip |
Description
See #18368, esp. ticket:18368#comment:6
Attachments (0)
Change History (11)
comment:1 by , 5 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
comment:2 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 by , 5 years ago
Cc: | added |
---|
@Vincent: I guess org.openstreetmap.josm.plugins.opendata.core.datasets.WayCombiner should also use this new method?
It is only used in org.openstreetmap.josm.plugins.opendata.modules.fr.paris.datasets.urbanisme.SanisettesHandler
comment:5 by , 5 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
The wanted result is a joined way, not the message that the ways cannot be joined. So, we need a datastructure that remembers the complete data.
comment:6 by , 5 years ago
@Gerd: I have removed this class in [o35244:35245]. Not worth keeping it.
comment:7 by , 5 years ago
There's a Sonar warning: https://josm.openstreetmap.de/sonar/project/issues?id=josm&issues=AW7MgRMl-XCMeap-x5vR&open=AW7MgRMl-XCMeap-x5vR
It would be safer to return an empty collection than null.
comment:8 by , 5 years ago
I also don't like it, but the older public method buildSpanningPath() does the same and callers expect the null value.
comment:9 by , 5 years ago
I don't find any plugin calling this method, so it is probably safe to change the behaviour if you want.
comment:10 by , 5 years ago
See also last patch in #18367. I can change the methods to private and let tryJoin() return an empty collection to signal that the ways cannot be joined.
In 15555/josm: