Modify

Opened 4 months ago

Closed 4 months ago

#18362 closed defect (fixed)

URISyntaxException at OpenBrowser.displayUrl

Reported by: pyrog Owned by: Don-vip
Priority: normal Milestone: 19.11
Component: Core Version:
Keywords: template_report Cc:

Description (last modified by pyrog)

What steps will reproduce the problem?

  1. url=http://kraeved.vp43.ru/wiki/Источник Бизек
  2. Select Show URL

What is the expected result?

Open the website

What happens instead?

nothing at all

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-24 21:23:35 +0100 (Sun, 24 Nov 2019)
Build-Date:2019-11-25 02:31:03
Revision:15541
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15541 fr) Mac OS X 10.14.6
OS Build number: Mac OS X 10.14.6 (18G95)
Memory Usage: 571 MB / 1820 MB (238 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69732928 1280x800
Maximum Screen Size: 1280x800
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/31/583aa85f-4a297e61, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Dmacosx.jnlpx.dock.name=JOSM (development version), -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-72a21903.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ CADTools (1008)
+ PicLayer (35104)
+ SeaMapEditor (34908)
+ apache-commons (35092)
+ apache-http (34908)
+ cadastre-fr (35194)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35014)
+ jna (34908)
+ jts (35122)
+ opendata (35179)
+ reverter (35226)
+ tag2link (35149)
+ utilsplugin2 (35230)
+ wikipedia (1.1.3)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ ${HOME}/Downloads/Rules_Pictures.validator.mapcss

Last errors/warnings:
- W: Identifiant de territoire inconnu: JA
- W: java.net.SocketTimeoutException: connect timed out
- W: Already here java.net.SocketException: Network is unreachable (connect failed)
- E: java.net.SocketTimeoutException: connect timed out
- W: org.openstreetmap.josm.io.OsmTransferException: Impossible de joindre le serveur. Veuillez vérifier votre connexion Internet.. Cause : java.net.SocketTimeoutException: connect timed out
- E: Illegal character in path at index 32: https://www.wikiwand.com/vi/Thảo Cầm Viên Sài Gòn
- E: Illegal character in path at index 32: https://www.wikiwand.com/vi/Thảo Cầm Viên Sài Gòn
- E: Handled by bug report queue: java.lang.AssertionError: Primitive {Node id=5061338419 version=2 VT lat=16.6206705,lon=97.895485} was removed when purging, but is still there on undo
- E: Illegal character in path at index 36: http://kraeved.vp43.ru/wiki/Источник Бизек
- E: Illegal character in path at index 36: http://kraeved.vp43.ru/wiki/Источник Бизек

Attachments (0)

Change History (6)

comment:1 Changed 4 months ago by pyrog

Description: modified (diff)

comment:2 Changed 4 months ago by pyrog

Founded other cases:

  • url=https://incubator.m.wikimedia.org/wiki/Wp/mnw/သာံလှေဝ်၊ ကွာန်
  • url=https://regiowiki.pnp.de/wiki/Abrahamhof (Neuburg)
  • url=http://wikimapia.org/#lang=ru&lat=42.854874&lon=41.812913&z=16&m=w&show=/39620049/ru/Водопад-Золотоносец-&search=42.854742, 41.805551

But this one works

  • url=http://wikimapia.org/39620049/ru/Водопад-Золотоносец

Source: https://trac.openstreetmap.org/browser/subversion/applications/editors/josm/plugins/tag2link/resources/tag2link_sources.xml#L36

Last edited 4 months ago by pyrog (previous) (diff)

comment:3 Changed 4 months ago by Don-vip

Component: Plugin tag2linkCore
Owner: changed from Don-vip to team

comment:4 Changed 4 months ago by Don-vip

Summary: tag2link can't open some linksURISyntaxException at OpenBrowser.displayUrl

comment:5 Changed 4 months ago by Don-vip

Milestone: 19.11
Owner: changed from team to Don-vip
Status: newassigned

comment:6 Changed 4 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15543/josm:

fix #18362 - safer construction of URIs

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.